Skip to content

Commit bdbada8

Browse files
committed
Address review comment from Copilot: align mixed batch network type semconv
1 parent 49e75eb commit bdbada8

4 files changed

Lines changed: 14 additions & 5 deletions

File tree

  • instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db
  • instrumentation/cassandra

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/MultiQuery.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ static class Builder {
5656
private final Set<String> uniqueQueryTexts = new LinkedHashSet<>();
5757
private final UniqueValue uniqueQuerySummary = new UniqueValue();
5858

59-
void add(SqlQuery analyzedQuery, String queryText) {
59+
void add(SqlQuery analyzedQuery, @Nullable String queryText) {
6060
uniqueStoredProcedureName.set(analyzedQuery.getStoredProcedureName());
6161
uniqueQueryTexts.add(queryText);
6262
uniqueQuerySummary.set(analyzedQuery.getQuerySummary());

instrumentation/cassandra/cassandra-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ void batchStatementWithDifferentQueries() {
374374
.hasKind(SpanKind.CLIENT)
375375
.hasNoParent()
376376
.hasAttributesSatisfyingExactly(
377-
equalTo(NETWORK_TYPE, "ipv4"),
377+
equalTo(NETWORK_TYPE, emitStableDatabaseSemconv() ? null : "ipv4"),
378378
equalTo(SERVER_ADDRESS, cassandraHost),
379379
equalTo(SERVER_PORT, cassandraPort),
380380
equalTo(NETWORK_PEER_ADDRESS, cassandraIp),

instrumentation/cassandra/cassandra-4.4/library/src/main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraRequest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ static CassandraRequest create(Session session, Statement<?> statement) {
3636
if (statement instanceof BatchStatement) {
3737
return create(session, (BatchStatement) statement);
3838
}
39-
return create(session, singleton(getQuery(statement)), statement instanceof BoundStatement, null, null);
39+
return create(
40+
session, singleton(getQuery(statement)), statement instanceof BoundStatement, null, null);
4041
}
4142

4243
private static CassandraRequest create(Session session, BatchStatement batchStatement) {

instrumentation/cassandra/cassandra-common-4.0/testing/src/main/java/io/opentelemetry/cassandra/common/v4_0/AbstractCassandraTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,11 @@ void batchStatementWithSameQuery() {
159159
.hasKind(SpanKind.CLIENT)
160160
.hasNoParent()
161161
.hasAttributesSatisfyingExactly(
162-
satisfies(NETWORK_TYPE, val -> val.isIn("ipv4", "ipv6")),
162+
satisfies(
163+
NETWORK_TYPE,
164+
emitStableDatabaseSemconv()
165+
? val -> val.isNull()
166+
: val -> val.isIn("ipv4", "ipv6")),
163167
equalTo(SERVER_ADDRESS, cassandraHost),
164168
equalTo(SERVER_PORT, cassandraPort),
165169
equalTo(NETWORK_PEER_ADDRESS, cassandraIp),
@@ -221,7 +225,11 @@ void batchStatementWithDifferentQueries() {
221225
.hasKind(SpanKind.CLIENT)
222226
.hasNoParent()
223227
.hasAttributesSatisfyingExactly(
224-
satisfies(NETWORK_TYPE, val -> val.isIn("ipv4", "ipv6")),
228+
satisfies(
229+
NETWORK_TYPE,
230+
emitStableDatabaseSemconv()
231+
? val -> val.isNull()
232+
: val -> val.isIn("ipv4", "ipv6")),
225233
equalTo(SERVER_ADDRESS, cassandraHost),
226234
equalTo(SERVER_PORT, cassandraPort),
227235
equalTo(NETWORK_PEER_ADDRESS, cassandraIp),

0 commit comments

Comments
 (0)