Skip to content

Commit ca9ebf1

Browse files
fix(deps): update error-prone monorepo to v2.50.0 (#18957)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
1 parent 4a65b0d commit ca9ebf1

18 files changed

Lines changed: 124 additions & 96 deletions

File tree

conventions/src/main/kotlin/otel.errorprone-conventions.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ tasks {
135135
disable("AddNullMarkedToClass")
136136
disable("AddNullMarkedToPackageInfo")
137137

138+
disable("ReferenceEquality")
139+
138140
if (otelProps.testLatestDeps) {
139141
// Some latest dep tests are compiled for java 17 although the base version uses an older
140142
// version. Disable rules that suggest using new language features.
@@ -158,6 +160,7 @@ tasks {
158160
disable("OtelCanIgnoreReturnValueSuggester")
159161
disable("OtelInternalJavadoc")
160162
disable("SuppressWarningsWithoutExplanation")
163+
disable("ExposedPrivateType")
161164
}
162165
}
163166
}

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ val DEPENDENCY_BOMS = listOf(
3737

3838
val autoServiceVersion = "1.1.1"
3939
val autoValueVersion = "1.11.1"
40-
val errorProneVersion = "2.49.0"
40+
val errorProneVersion = "2.50.0"
4141
val byteBuddyVersion = "1.18.10"
4242
val asmVersion = "9.10.1"
4343
val jmhVersion = "1.37"

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/service/peer/internal/ServicePeerResolver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public void resolve(
122122
}
123123

124124
@Nullable
125-
ServicePeer resolveServicePeer(
125+
private ServicePeer resolveServicePeer(
126126
String host, @Nullable Integer port, Supplier<String> pathSupplier) {
127127
Map<ServiceMatcher, ServicePeer> matchers = servicePeerMapping.get(host);
128128
if (matchers == null) {

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/cache/weaklockfree/AbstractWeakConcurrentMap.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,12 @@
4949
* https://github.com/raphw/weak-lock-free/blob/ad0e5e0c04d4a31f9485bf12b89afbc9d75473b3/src/main/java/com/blogspot/mydailyjava/weaklockfree/WeakConcurrentMap.java
5050
*/
5151
// Suppress warnings since this is vendored as-is.
52-
@SuppressWarnings({"MissingSummary", "EqualsBrokenForNull", "FieldMissingNullable"})
52+
@SuppressWarnings({
53+
"MissingSummary",
54+
"EqualsBrokenForNull",
55+
"FieldMissingNullable",
56+
"ReferenceEquality"
57+
})
5358
abstract class AbstractWeakConcurrentMap<K, V, L> implements Iterable<Map.Entry<K, V>> {
5459

5560
private static final ReferenceQueue<Object> REFERENCE_QUEUE = new ReferenceQueue<>();

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/cache/weaklockfree/WeakConcurrentMap.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
"MissingSummary",
5151
"UngroupedOverloads",
5252
"FieldMissingNullable",
53-
"SuppressWarningsWithoutExplanation"
53+
"SuppressWarningsWithoutExplanation",
54+
"ReferenceEquality"
5455
})
5556
public class WeakConcurrentMap<K, V>
5657
extends AbstractWeakConcurrentMap<K, V, WeakConcurrentMap.LookupKey<K>> {

instrumentation-docs/src/main/java/io/opentelemetry/instrumentation/docs/parsers/EmittedScopeParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private static EmittedScope.Scope findScopeByName(
9090
Set<EmittedScope.Scope> scopes, String scopeName) {
9191
return scopes.stream()
9292
.filter(scope -> scopeName.equals(scope.getName()))
93-
.min(Comparator.comparing(scope -> scope.getSchemaUrl() == null ? 1 : 0))
93+
.min(Comparator.comparingInt(scope -> scope.getSchemaUrl() == null ? 1 : 0))
9494
.orElse(null);
9595
}
9696

instrumentation/executors/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/executors/AbstractExecutorServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ protected void executeAndCancelTasks(Function<U, Future<?>> task) {
158158
}
159159

160160
jobFutures.forEach(f -> f.cancel(false));
161-
children.forEach(U::unblock);
161+
children.forEach(TestTask::unblock);
162162
});
163163

164164
// Just check there is a single trace, this test is primarily to make sure that scopes aren't

instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/AbstractOpenTelemetryMetricsReporterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ private static void printMappingTable() {
430430
kafkaMetricsByGroup.get(group).stream()
431431
.sorted(
432432
comparing(KafkaMetricId::getName)
433-
.thenComparing(kafkaMetricId -> kafkaMetricId.getAttributeKeys().size()))
433+
.thenComparingInt(kafkaMetricId -> kafkaMetricId.getAttributeKeys().size()))
434434
.collect(toList());
435435
// Iterate through metrics in alpha order by name
436436
for (KafkaMetricId kafkaMetricId : kafkaMetricIds) {

instrumentation/micrometer/micrometer-1.5/library/src/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryDistributionSummary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ private interface Measurements {
125125

126126
// if micrometer histograms are not being used then there's no need to keep any local state
127127
// OpenTelemetry metrics bridge does not support reading measurements
128-
enum NoopMeasurements implements Measurements {
128+
private enum NoopMeasurements implements Measurements {
129129
INSTANCE;
130130

131131
@Override

instrumentation/micrometer/micrometer-1.5/library/src/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryTimer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ private interface Measurements {
139139

140140
// if micrometer histograms are not being used then there's no need to keep any local state
141141
// OpenTelemetry metrics bridge does not support reading measurements
142-
enum NoopMeasurements implements Measurements {
142+
private enum NoopMeasurements implements Measurements {
143143
INSTANCE;
144144

145145
@Override

0 commit comments

Comments
 (0)