Review fixes for jms-common:javaagent (#18097)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>

Author: otelbot[bot]

instrumentation/jms/jms-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jms/MessagePropertyGetter.java

@@ -6,18 +6,23 @@
 package io.opentelemetry.javaagent.instrumentation.jms;
 
 import static java.util.Collections.emptyList;
+import static java.util.logging.Level.FINE;
 
 import io.opentelemetry.context.propagation.TextMapGetter;
+import java.util.logging.Logger;
 import javax.annotation.Nullable;
 
 enum MessagePropertyGetter implements TextMapGetter<MessageWithDestination> {
   INSTANCE;
 
+  private static final Logger logger = Logger.getLogger(MessagePropertyGetter.class.getName());
+
   @Override
   public Iterable<String> keys(MessageWithDestination message) {
     try {
       return message.message().getPropertyNames();
     } catch (Exception e) {
+      logger.log(FINE, "Failure getting JMS property names", e);
       return emptyList();
     }
   }
@@ -33,7 +38,8 @@ public String get(@Nullable MessageWithDestination carrier, String key) {
     try {
       value = carrier.message().getObjectProperty(propName);
     } catch (Exception e) {
-      throw new IllegalStateException(e);
+      logger.log(FINE, "Failure getting JMS property: " + propName, e);
+      return null;
     }
     if (value instanceof String) {
       return (String) value;

instrumentation/jms/jms-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jms/MessageWithDestination.java

@@ -5,12 +5,17 @@
 
 package io.opentelemetry.javaagent.instrumentation.jms;
 
+import static java.util.logging.Level.FINE;
+
 import com.google.auto.value.AutoValue;
+import java.util.logging.Logger;
 import javax.annotation.Nullable;
 
 @AutoValue
 public abstract class MessageWithDestination {
 
+  private static final Logger logger = Logger.getLogger(MessageWithDestination.class.getName());
+
   // visible for tests
   static final String TIBCO_TMP_PREFIX = "$TMP$";
 
@@ -25,8 +30,8 @@ public static MessageWithDestination create(
     DestinationAdapter jmsDestination = null;
     try {
       jmsDestination = message.getJmsDestination();
-    } catch (Exception ignored) {
-      // Ignore
+    } catch (Exception e) {
+      logger.log(FINE, "Failure getting JMS destination", e);
     }
     if (jmsDestination == null) {
       jmsDestination = fallbackDestination;
@@ -66,6 +71,7 @@ private static String getDestinationName(DestinationAdapter destination, NameGet
     try {
       return nameGetter.getName(destination);
     } catch (Exception e) {
+      logger.log(FINE, "Failure getting JMS destination name", e);
       return "unknown";
     }
   }