Skip to content

Commit dfbf501

Browse files
v3_preview applied for lowercase normalization for <name> in servlet.… (#17822)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
1 parent ebcbd27 commit dfbf501

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

instrumentation/servlet/servlet-common/library/src/main/java/io/opentelemetry/instrumentation/servlet/internal/ServletRequestParametersExtractor.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import io.opentelemetry.api.common.AttributesBuilder;
1010
import io.opentelemetry.context.Context;
1111
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
12+
import io.opentelemetry.instrumentation.api.internal.SemconvStability;
1213
import java.util.Collection;
1314
import java.util.List;
1415
import java.util.Locale;
@@ -72,9 +73,11 @@ private static AttributeKey<List<String>> parameterAttributeKey(String headerNam
7273
}
7374

7475
private static AttributeKey<List<String>> createKey(String parameterName) {
75-
// normalize parameter name similarly as is done with header names when header values are
76-
// captured as span attributes
77-
parameterName = parameterName.toLowerCase(Locale.ROOT);
76+
if (!SemconvStability.v3Preview()) {
77+
// normalize parameter name similarly as is done with header names when header values are
78+
// captured as span attributes
79+
parameterName = parameterName.toLowerCase(Locale.ROOT);
80+
}
7881
String key = "servlet.request.parameter." + parameterName;
7982
return AttributeKey.stringArrayKey(key);
8083
}

0 commit comments

Comments
 (0)