Optimize code

Author: steverao

instrumentation/apache-dubbo-2.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachedubbo/v2_7/RegistryCapturingClusterWrapperProxy.java

@@ -10,10 +10,6 @@
 import org.apache.dubbo.rpc.cluster.Cluster;
 import org.apache.dubbo.rpc.cluster.Directory;
 
-/**
- * Javaagent proxy for {@link RegistryCapturingClusterWrapper}. Dubbo SPI discovers this class by
- * name, so it must live in the javaagent module (which is not shaded) to keep a stable class name.
- */
 public final class RegistryCapturingClusterWrapperProxy implements Cluster {
 
   private final RegistryCapturingClusterWrapper delegate;

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/internal/DubboClientNetworkAttributesGetter.java

@@ -5,6 +5,9 @@
 
 package io.opentelemetry.instrumentation.apachedubbo.v2_7.internal;
 
+import static io.opentelemetry.instrumentation.apachedubbo.v2_7.internal.DubboRegistryUtil.buildServiceTarget;
+import static io.opentelemetry.instrumentation.apachedubbo.v2_7.internal.DubboRegistryUtil.extractRegistryAddress;
+
 import io.opentelemetry.instrumentation.apachedubbo.v2_7.DubboRequest;
 import io.opentelemetry.instrumentation.api.semconv.network.NetworkAttributesGetter;
 import io.opentelemetry.instrumentation.api.semconv.network.ServerAttributesGetter;
@@ -22,17 +25,17 @@ public final class DubboClientNetworkAttributesGetter
   @Nullable
   @Override
   public String getServerAddress(DubboRequest request) {
-    String registryAddress = DubboRegistryUtil.extractRegistryAddress(request.invocation());
+    String registryAddress = extractRegistryAddress(request.invocation());
     if (registryAddress != null) {
-      return registryAddress + "/" + DubboRegistryUtil.buildServiceTarget(request.url());
+      return registryAddress + "/" + buildServiceTarget(request.url());
     }
     return request.url().getHost();
   }
 
   @Nullable
   @Override
   public Integer getServerPort(DubboRequest request) {
-    if (DubboRegistryUtil.extractRegistryAddress(request.invocation()) != null) {
+    if (extractRegistryAddress(request.invocation()) != null) {
       return null;
     }
     return request.url().getPort();

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/internal/DubboRegistryUtil.java

@@ -184,8 +184,9 @@ private static MethodHandle resolveMethod(Class<?> clazz, String name) {
       m.setAccessible(true);
       return LOOKUP.unreflect(m);
     } catch (NoSuchMethodException | IllegalAccessException e) {
-      return null;
+      // ignore
     }
+    return null;
   }
 
   @Nullable
@@ -196,7 +197,7 @@ private static MethodHandle resolveField(Class<?> clazz, String name) {
         f.setAccessible(true);
         return LOOKUP.unreflectGetter(f);
       } catch (NoSuchFieldException | IllegalAccessException e) {
-        // continue up the hierarchy
+        // ignore
       }
     }
     return null;