Skip to content

Commit f35a444

Browse files
authored
Improve Vert.x Redis stable metric test (#19009)
1 parent c4d01f7 commit f35a444

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

  • instrumentation/vertx/vertx-redis-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/redisclient/v4_0

instrumentation/vertx/vertx-redis-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/redisclient/v4_0/VertxRedisClientTest.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
package io.opentelemetry.javaagent.instrumentation.vertx.redisclient.v4_0;
77

88
import static io.opentelemetry.instrumentation.api.internal.SemconvStability.emitStableDatabaseSemconv;
9+
import static io.opentelemetry.instrumentation.testing.junit.db.DbClientMetricsTestUtil.assertDurationMetric;
910
import static io.opentelemetry.instrumentation.testing.junit.service.SemconvServiceStabilityUtil.maybeStablePeerService;
1011
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
1112
import static io.opentelemetry.semconv.DbAttributes.DB_NAMESPACE;
@@ -89,11 +90,16 @@ void setCommand() throws Exception {
8990
.hasKind(SpanKind.CLIENT)
9091
.hasAttributesSatisfyingExactly(redisSpanAttributes("SET", "SET foo ?"))));
9192

92-
if (emitStableDatabaseSemconv()) {
93-
testing.waitAndAssertMetrics(
94-
"io.opentelemetry.vertx-redis-client-4.0",
95-
metric -> metric.hasName("db.client.operation.duration"));
96-
}
93+
assertDurationMetric(
94+
testing,
95+
"io.opentelemetry.vertx-redis-client-4.0",
96+
DB_SYSTEM_NAME,
97+
DB_OPERATION_NAME,
98+
DB_NAMESPACE,
99+
SERVER_ADDRESS,
100+
SERVER_PORT,
101+
NETWORK_PEER_ADDRESS,
102+
NETWORK_PEER_PORT);
97103
}
98104

99105
@Test

0 commit comments

Comments
 (0)