Pass openTelemetry parameter in README client wrapper examples

trask · trask · commit f4e6b67e0837 · 2026-05-10T16:03:28.000-07:00
diff --git a/instrumentation/thrift-0.13/library/README.md b/instrumentation/thrift-0.13/library/README.md
@@ -43,7 +43,7 @@ TProtocol configureClient(OpenTelemetry openTelemetry, TProtocol protocol) {
   return thriftTelemetry.wrapClientProtocol(protocol);
 }
 
-CustomService.Iface configureClient(CustomService.Client client) {
+CustomService.Iface configureClient(OpenTelemetry openTelemetry, CustomService.Client client) {
   ThriftTelemetry thriftTelemetry = ThriftTelemetry.create(openTelemetry);
   return thriftTelemetry.wrapClient(client, CustomService.Iface.class);
 }
@@ -54,7 +54,7 @@ TProtocolFactory configureClient(OpenTelemetry openTelemetry, TProtocolFactory p
   return thriftTelemetry.wrapClientProtocolFactory(protocolFactory);
 }
 
-CustomService.AsyncIface configureClient(CustomService.AsyncClient asyncClient) {
+CustomService.AsyncIface configureClient(OpenTelemetry openTelemetry, CustomService.AsyncClient asyncClient) {
   ThriftTelemetry thriftTelemetry = ThriftTelemetry.create(openTelemetry);
   return thriftTelemetry.wrapAsyncClient(asyncClient, CustomService.AsyncIface.class);
 }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ TProtocol configureClient(OpenTelemetry openTelemetry, TProtocol protocol) {`
`43`	`43`	`return thriftTelemetry.wrapClientProtocol(protocol);`
`44`	`44`	`}`
`45`	`45`
`46`		`-CustomService.Iface configureClient(CustomService.Client client) {`
	`46`	`+CustomService.Iface configureClient(OpenTelemetry openTelemetry, CustomService.Client client) {`
`47`	`47`	`ThriftTelemetry thriftTelemetry = ThriftTelemetry.create(openTelemetry);`
`48`	`48`	`return thriftTelemetry.wrapClient(client, CustomService.Iface.class);`
`49`	`49`	`}`
`@@ -54,7 +54,7 @@ TProtocolFactory configureClient(OpenTelemetry openTelemetry, TProtocolFactory p`
`54`	`54`	`return thriftTelemetry.wrapClientProtocolFactory(protocolFactory);`
`55`	`55`	`}`
`56`	`56`
`57`		`-CustomService.AsyncIface configureClient(CustomService.AsyncClient asyncClient) {`
	`57`	`+CustomService.AsyncIface configureClient(OpenTelemetry openTelemetry, CustomService.AsyncClient asyncClient) {`
`58`	`58`	`ThriftTelemetry thriftTelemetry = ThriftTelemetry.create(openTelemetry);`
`59`	`59`	`return thriftTelemetry.wrapAsyncClient(asyncClient, CustomService.AsyncIface.class);`
`60`	`60`	`}`