Skip to content

Commit f6f123d

Browse files
authored
Preserve Spring resource provider class names (#18785)
1 parent 4c6155a commit f6f123d

6 files changed

Lines changed: 51 additions & 7 deletions

File tree

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.instrumentation.spring.resources;
7+
8+
import com.google.auto.service.AutoService;
9+
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
10+
11+
// In 3.0, switch the AutoService annotation to
12+
// io.opentelemetry.javaagent.instrumentation.spring.boot.resources.
13+
@Deprecated // to be removed in 3.0
14+
@AutoService(ResourceProvider.class)
15+
public class SpringBootServiceNameDetector
16+
extends io.opentelemetry.javaagent.instrumentation.spring.boot.resources
17+
.SpringBootServiceNameDetector {}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.instrumentation.spring.resources;
7+
8+
import com.google.auto.service.AutoService;
9+
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
10+
11+
// In 3.0, switch the AutoService annotation to
12+
// io.opentelemetry.javaagent.instrumentation.spring.boot.resources.
13+
@Deprecated // to be removed in 3.0
14+
@AutoService(ResourceProvider.class)
15+
public class SpringBootServiceVersionDetector
16+
extends io.opentelemetry.javaagent.instrumentation.spring.boot.resources
17+
.SpringBootServiceVersionDetector {}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.instrumentation.spring.resources;
7+
8+
import com.google.auto.service.AutoService;
9+
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
10+
11+
// In 3.0, switch the AutoService annotation to
12+
// io.opentelemetry.javaagent.instrumentation.spring.boot.resources.
13+
@Deprecated // to be removed in 3.0
14+
@AutoService(ComponentProvider.class)
15+
public class SpringResourceComponentProvider
16+
extends io.opentelemetry.javaagent.instrumentation.spring.boot.resources
17+
.SpringResourceComponentProvider {}

instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceNameDetector.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
import static java.util.logging.Level.FINE;
1010
import static java.util.logging.Level.FINER;
1111

12-
import com.google.auto.service.AutoService;
1312
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
1413
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
15-
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
1614
import io.opentelemetry.sdk.autoconfigure.spi.internal.ConditionalResourceProvider;
1715
import io.opentelemetry.sdk.resources.Resource;
1816
import java.io.IOException;
@@ -55,7 +53,6 @@
5553
* <p>Note: The spring starter already includes provider in
5654
* io.opentelemetry.instrumentation.spring.autoconfigure.resources.SpringResourceProvider
5755
*/
58-
@AutoService(ResourceProvider.class)
5956
public class SpringBootServiceNameDetector implements ConditionalResourceProvider {
6057

6158
private static final Logger logger =

instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceVersionDetector.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_VERSION;
99
import static java.util.logging.Level.FINE;
1010

11-
import com.google.auto.service.AutoService;
1211
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
1312
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1413
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
@@ -23,7 +22,6 @@
2322
* Note: The spring starter already includes provider in
2423
* io.opentelemetry.instrumentation.spring.autoconfigure.resources.SpringResourceProvider
2524
*/
26-
@AutoService(ResourceProvider.class)
2725
public class SpringBootServiceVersionDetector implements ResourceProvider {
2826

2927
private static final Logger logger =

instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringResourceComponentProvider.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.spring.boot.resources;
77

8-
import com.google.auto.service.AutoService;
98
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
109
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
1110
import io.opentelemetry.sdk.resources.Resource;
@@ -16,7 +15,6 @@
1615
* <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
1716
* at any time.
1817
*/
19-
@AutoService(ComponentProvider.class)
2018
public class SpringResourceComponentProvider implements ComponentProvider {
2119

2220
@Override

0 commit comments

Comments
 (0)