Tighten TAsyncClient constructor matcher and drop unused transport binding

Author: trask

instrumentation/thrift-0.13/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/thrift/v0_13/ThriftAsyncClientInstrumentation.java

@@ -14,6 +14,7 @@
 import static net.bytebuddy.matcher.ElementMatchers.named;
 import static net.bytebuddy.matcher.ElementMatchers.not;
 import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
+import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
 
 import io.opentelemetry.instrumentation.thrift.v0_13.internal.AsyncMethodCallbackUtil;
 import io.opentelemetry.instrumentation.thrift.v0_13.internal.ClientCallContext;
@@ -29,7 +30,6 @@
 import org.apache.thrift.async.AsyncMethodCallback;
 import org.apache.thrift.async.TAsyncClient;
 import org.apache.thrift.protocol.TProtocolFactory;
-import org.apache.thrift.transport.TNonblockingTransport;
 
 class ThriftAsyncClientInstrumentation implements TypeInstrumentation {
 
@@ -47,7 +47,10 @@ public ElementMatcher<ClassLoader> classLoaderOptimization() {
   @Override
   public void transform(TypeTransformer transformer) {
     transformer.applyAdviceToMethod(
-        isConstructor().and(takesArgument(0, named("org.apache.thrift.protocol.TProtocolFactory"))),
+        isConstructor()
+            .and(takesArguments(3))
+            .and(takesArgument(0, named("org.apache.thrift.protocol.TProtocolFactory")))
+            .and(takesArgument(2, named("org.apache.thrift.transport.TNonblockingTransport"))),
         getClass().getName() + "$ConstructorAdvice");
 
     transformer.applyAdviceToMethod(
@@ -69,9 +72,7 @@ public void transform(TypeTransformer transformer) {
   public static class ConstructorAdvice {
     @Advice.AssignReturned.ToArguments(@ToArgument(0))
     @Advice.OnMethodEnter(suppress = Throwable.class, inline = false)
-    public static TProtocolFactory onEnter(
-        @Advice.Argument(0) TProtocolFactory protocolFactory,
-        @Advice.Argument(2) TNonblockingTransport transport) {
+    public static TProtocolFactory onEnter(@Advice.Argument(0) TProtocolFactory protocolFactory) {
       return new ClientProtocolDecorator.Factory(protocolFactory, getPropagators());
     }
   }