SpringWebfluxServerTelemetry has
|
public WebFilter createWebFilter() { |
and
|
public WebFilter createWebFilterAndRegisterReactorHook() { |
similarly
SpringWebfluxClientTelemetry has
|
public void addFilter(List<ExchangeFilterFunction> exchangeFilterFunctions) { |
and
|
public void addFilterAndRegisterReactorHook( |
I think it would be better if we had only one of these, if reactor instrumenation is necessary for these instrumenation to function correctly then we could always enable it. Alternatively it would be nice if we could provide guidance on when to use the one that registers the reactor hook.
SpringWebfluxServerTelemetryhasopentelemetry-java-instrumentation/instrumentation/spring/spring-webflux/spring-webflux-5.3/library/src/main/java/io/opentelemetry/instrumentation/spring/webflux/v5_3/SpringWebfluxServerTelemetry.java
Line 36 in 5b6a0d3
and
opentelemetry-java-instrumentation/instrumentation/spring/spring-webflux/spring-webflux-5.3/library/src/main/java/io/opentelemetry/instrumentation/spring/webflux/v5_3/SpringWebfluxServerTelemetry.java
Line 44 in 5b6a0d3
similarly
SpringWebfluxClientTelemetryhasopentelemetry-java-instrumentation/instrumentation/spring/spring-webflux/spring-webflux-5.3/library/src/main/java/io/opentelemetry/instrumentation/spring/webflux/v5_3/SpringWebfluxClientTelemetry.java
Line 45 in 5b6a0d3
and
opentelemetry-java-instrumentation/instrumentation/spring/spring-webflux/spring-webflux-5.3/library/src/main/java/io/opentelemetry/instrumentation/spring/webflux/v5_3/SpringWebfluxClientTelemetry.java
Line 60 in 5b6a0d3
I think it would be better if we had only one of these, if reactor instrumenation is necessary for these instrumenation to function correctly then we could always enable it. Alternatively it would be nice if we could provide guidance on when to use the one that registers the reactor hook.