Add spotless auto-fix for PRs#13872
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
7 times, most recently
from
cfcb00c to
7d32550
Compare
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
from
7d32550 to
e27afad
Compare
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
2 times, most recently
from
b9dbb65 to
ebfe4f0
Compare
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
from
ebfe4f0 to
9e0ba88
Compare
trask
commented
May 17, 2025
laurit
reviewed
May 19, 2025
| - name: Use CLA approved github bot | ||
| if: steps.download-patch.outputs.exists == 'true' | ||
| # IMPORTANT do not call the .github/scripts/use-cla-approved-bot.sh | ||
| # since that script could have been compromised in the PR branch |
Contributor
There was a problem hiding this comment.
just curious, would running the script be ok if it happened before gh pr checkout?
Member
Author
There was a problem hiding this comment.
it's ok, it just needs to be after actions/checkout above. gh pr checkout is just doing a branch checkout.
laurit
approved these changes
May 19, 2025
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
from
747a6a6 to
df211f1
Compare
Member
Author
|
ok, let's give it a spin... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally a safe way to auto-fix PRs, thanks @svrnm!! open-telemetry/opentelemetry.io#6894
This will automatically update PRs with spotlessApply if needed.
UPDATE: still not safe per CodeQL warnings below! working through the warnings to see if we can still make this happen...