Allow excluding Logback MDC attributes from being copied

[cfredri4]

Closes #14925

[otelbot-java-instrumentation]

🔧 The result from spotlessApply was committed to the PR branch.

[trask]

my initial thought is that this should be the default behavior (for both javaagent and library instrumentation), and you should have to opt in somehow if you want the duplication (e.g. #14897 / #14904)

[cfredri4]

@trask additional context: I use Micrometer for tracing which adds the MDC values traceId, spanId (i.e. different from trace_id and span_id exported by the appender).

[laurit]

@cfredri4 if your intention is to get this merged then you firstly need to fix the compilation errors in your PR. Secondly you'll have to add tests. Ideally this functionality should be present for both the library and javaagent instrumentation in all relevant logging instrumentations.

[github-actions]

This PR has been labeled as stale due to lack of activity and needing author feedback. It will be automatically closed if there is no further activity over the next 7 days.

[cfredri4]

@laurit I'll take a look at the other logging instrumentations, and tests.

Ideally this functionality should be present for both the library and javaagent instrumentation

Can you elaborate on what this means specifically?

[laurit]

Can you elaborate on what this means specifically?

Besides logback library instrumentation (by library instrumentation we mean standalone instrumetnation that can be used without the agent) capturing mdc attributes is also implemented in the logback javaagent instrumentation (uses the library instrumentation, but is configured differently), log4j 1&2 and jboss logmanager. Search for capture-mdc-attribute. Ideally there should be feature parity between these instrumentations.

[github-actions]

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days.

[cfredri4]

Still working on this.

[trask]

Just doing some housekeeping, marking this as draft, just switch it back to "ready for review" once you're ready

[philsttr]

I just found this PR after filing a similar PR (#18912), which covers all logging instrumentations.

[cfredri4]

Closed in favor of #18912