Add waitAndAssertLogRecords to InstrumentationTestRunner#16052
Merged
Conversation
trask
force-pushed
the
exceptions-test-runner
branch
from
450a366 to
a7d9b0a
Compare
laurit
reviewed
Jan 29, 2026
| assertions.forEach(assertionsList::add); | ||
|
|
||
| List<LogRecordData> logRecordDataList = waitForLogRecords(assertionsList.size()); | ||
| Iterator<Consumer<LogRecordDataAssert>> assertionIterator = assertionsList.iterator(); |
Contributor
There was a problem hiding this comment.
I initially thought that there should be awaitUntilAsserted like in metrics and trace assertions but it really isn't needed since we know how many log records are needed.
laurit
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better follows the pattern of spans and metrics, and needed for #16049 to be able to assert on logs directly from InstrumentationTestRunner.