Add opt-in support for emitting exceptions as log signals#16259
Merged
Conversation
trask
force-pushed
the
exceptions-over-log-signal
branch
2 times, most recently
from
e5ccd7d to
bc09a65
Compare
trask
commented
Feb 22, 2026
trask
force-pushed
the
exceptions-over-log-signal
branch
from
bc09a65 to
161b795
Compare
trask
force-pushed
the
exceptions-over-log-signal
branch
from
161b795 to
0d2f88b
Compare
3 tasks
laurit
reviewed
Mar 2, 2026
…-signal # Conflicts: # instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterTest.java
trask
force-pushed
the
exceptions-over-log-signal
branch
from
ab473e9 to
d06b0e9
Compare
laurit
reviewed
Mar 3, 2026
laurit
approved these changes
Mar 3, 2026
1 task
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/review |
1 similar comment
Member
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean review. The PR correctly implements otel.semconv.exception.signal.preview to support emitting exceptions as logs, following the established SemconvStability pattern. Flag parsing, Instrumenter wiring, test task setup, and assertion gating all look correct. No substantive issues found.
Triggered by: /review by @trask. Model: gpt-5.
Member
Author
|
/review gpt-5.5 |
Contributor
There was a problem hiding this comment.
Found one issue with exception log event naming for a manually-built HTTP client instrumenter.
Triggered by: /review by @trask. Model: gpt-5.5.
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span events are in the process of being deprecated.
This starts to add opt-in support for emitting exceptions as logs (as opposed to span events).
Follows semantic conventions proposal: open-telemetry/semantic-conventions#3414
See #16049 for how this will be used, this PR is just laying the foundation.