-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add opt-in support for emitting exceptions as log signals #16259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
0d2f88b
Add opt-in support for emitting exceptions as log signals
trask ca470b9
Merge branch 'main' into exceptions-over-log-signal
trask 5732f14
Merge remote-tracking branch 'upstream/main' into exceptions-over-log…
trask d06b0e9
Add default ExceptionEventExtractor
trask 9b2df30
update assertion pattern
trask 79d41ef
Merge branch 'main' into exceptions-over-log-signal
trask 02f15a8
update
trask 7964b79
Merge remote-tracking branch 'upstream/main' into exceptions-over-log…
trask 1df0fb1
update
trask 078fb6b
update fallback event name based on latest semconv PR updates
trask bc15ede
spotless
trask fdde948
Merge branch 'main' into exceptions-over-log-signal
trask debd045
update to latest semconv
trask 54c294e
simplify
trask ce9ef4b
Update HTTP test schema URL expectations
trask fa4c66c
Update Netty 3.8 connection schema URL
trask cb39859
Fix PR CI failures
trask 7d2faa2
back
trask ad1c897
spotless
trask 1c3e7b9
fix
trask ba08868
Apply review feedback
trask d82a2e2
tests
trask 8d4f7bb
fix
trask 403d742
spotless
trask ed72463
fix
trask 6081ccf
Address review comments: collectMetadata for all Test tasks; include …
trask e69afd1
up
trask e931a9f
Potential fix for pull request finding
trask ea5c42e
declarative config
trask 15bcc10
review
trask 4768165
review
trask b6295c4
Fix WebFlux exception signal log assertions
trask 88d9766
spotless
trask 2ddd571
Assert no exception span event in logs-only mode
trask c22e3fa
fix
trask cde1b63
Merge branch 'main' into exceptions-over-log-signal
trask 2d29ba0
review
trask c204a4d
Drop redundant Assertions.assertThat static import in spring-webflux …
trask 8ea9f27
Merge remote-tracking branch 'upstream/main' into exceptions-over-log…
trask 0051a0b
rename opt-in to preview
trask d0ecb52
Potential fix for pull request finding
trask f721eef
Fix Netty connect exception log event name
trask 4ff6027
Clarify val lambda-parameter rule excludes custom assertion helpers
trask File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
...n/java/io/opentelemetry/instrumentation/api/internal/InternalExceptionEventExtractor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.instrumentation.api.internal; | ||
|
|
||
| import io.opentelemetry.api.logs.LogRecordBuilder; | ||
| import io.opentelemetry.context.Context; | ||
|
|
||
| /** | ||
| * Internal functional interface for exception event extraction. | ||
| * | ||
| * <p>This is temporary bridge API while exception event extraction is not available in the stable | ||
| * instrumentation API artifact. This interface should be revisited when a public API is added. | ||
| * | ||
| * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change | ||
| * at any time. | ||
| */ | ||
| @FunctionalInterface | ||
| public interface InternalExceptionEventExtractor<REQUEST> { | ||
|
|
||
| /** | ||
| * Populates the exception event {@link LogRecordBuilder} with the event name, severity, and any | ||
| * additional attributes for the given context and request. | ||
| */ | ||
| void extract(LogRecordBuilder logRecordBuilder, Context context, REQUEST request); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.