Skip to content

Style guide: clarify final for javaagent modules (option 2 - use final in javaagent modules)#17439

Closed
trask wants to merge 3 commits intoopen-telemetry:mainfrom
trask:final-alt
Closed

Style guide: clarify final for javaagent modules (option 2 - use final in javaagent modules)#17439
trask wants to merge 3 commits intoopen-telemetry:mainfrom
trask:final-alt

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Apr 2, 2026

#17344 (comment)

and applied to javaagent source

rg -l -0 --glob 'instrumentation/**/javaagent/src/main/java/**/*.java' '^public class ' | xargs -0 sed -i 's/^public class /public final class /'
./gradlew spotlessApply
git commit -a -m "Apply to javaagent files"

Option 1:

@trask trask marked this pull request as ready for review April 2, 2026 19:34
@trask trask requested a review from a team as a code owner April 2, 2026 19:34
@trask trask closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant