Delete advice transformation code#17471
Merged
laurit merged 5 commits intoopen-telemetry:mainfrom Apr 7, 2026
Merged
Conversation
SylvainJuge
reviewed
Apr 7, 2026
Contributor
There was a problem hiding this comment.
This instrumentation aims to represent an existing inlined instrumentation extension.
The difference is that now this is no longer modified at runtime when indy is enabled but always reused as-is (so always inlined).
If we want to avoid regressions for existing inlined instrumentation in extensions we should not modify it and keep the readOnly = false in the arguments.
Contributor
Author
There was a problem hiding this comment.
It still uses inlined advice but not by using @AssignReturned it can also be used as non-inlined without advice transformation (currently the only transform indy instrumentation uses is changing the value of inlined attribute). So I'd argue that it still tests inlined advice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of our advices seem to require transformation any more.