Merged
Conversation
Automated code review of instrumentation/r2dbc-1.0/javaagent.
trask
reviewed
Apr 6, 2026
trask
reviewed
Apr 6, 2026
Comment on lines
10
to
+27
| @@ -23,7 +24,7 @@ sourceSets { | |||
| } | |||
|
|
|||
| dependencies { | |||
| library("io.r2dbc:r2dbc-spi:1.0.0.RELEASE") | |||
| library("io.r2dbc:r2dbc-spi:0.9.0.RELEASE") | |||
Member
There was a problem hiding this comment.
@laurit I'm thinking to just leave the module name as 1.0, since it's a nice round number 😄
laurit
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied safe review fixes in
instrumentation/r2dbc-1.0/javaagent: corrected the boundedmuzzledeclaration to match actualr2dbc-spicoverage and aligned singleton-holder naming/access with javaagent conventions.Applied Changes
Build
File:
build.gradle.kts:10Change: Expanded the
muzzlerange toversions.set("[0.9.0.RELEASE,)")and addedassertInverse.set(true).Reason:
gradle-conventions.mdrequiresassertInverse.set(true)for boundedmuzzleranges, and the module's:muzzleresults showed this instrumentation already matchesr2dbc-spi0.9.x, so the declared lower bound needed to reflect the real supported range.Javaagent
File:
R2dbcInstrumentation.java:8Change: Static-imported
R2dbcSingletons.telemetry()and used the accessor unqualified insideFactoryAdvice.Reason:
javaagent-singletons-patterns.mdsays callers should static import exported singleton accessors and use them unqualified instead of qualifying them with the holder class.Style
File:
R2dbcSingletons.java:19Change: Renamed the shared
R2dbcTelemetryfield fromTELEMETRYtotelemetryso the field and accessor names match.Reason: The singleton-holder and style rules require runtime collaborator fields to use lower camel case, with the accessor using the same name; uppercase is reserved for constant-like identifiers, not service objects such as
R2dbcTelemetry.Download code review diagnostics