Review fixes for couchbase-common-2.0:javaagent-unit-tests#18118
Merged
trask merged 2 commits intoApr 22, 2026
Conversation
Automated code review of instrumentation/couchbase/couchbase-common-2.0/javaagent-unit-tests.
breedx-splk
approved these changes
Apr 22, 2026
…aagent-unit-tests
trask
reviewed
Apr 22, 2026
| @MethodSource("providesArguments") | ||
| void testShouldNormalizeStringQuery(Parameter parameter) { | ||
| String normalized = CouchbaseQuerySanitizer.analyze(parameter.query).getQueryText(); | ||
| assertThat(normalized).isNotNull(); |
trask
deleted the
otelbot/code-review-couchbase-common-2.0-javaagent-unit-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied one safe
[Testing]fix incouchbase-common-2.0 javaagent-unit-tests: removed a redundant preliminary AssertJ null check so the test keeps a single direct assertion on the normalized query value.Applied Changes
[Testing]
File:
CouchbaseQuerySanitizerTest.java:27Change: Removed the redundant
assertThat(normalized).isNotNull()before the normalized-query equality assertion intestShouldNormalizeStringQuery(...).Reason: Repository test guidance prefers direct AssertJ assertions without unnecessary extra assertion noise; the following equality assertion already fails clearly if
normalizedisnullor unexpected.Download code review diagnostics