Review fixes for testing-apps:testing-webapp#18119
Merged
Merged
Conversation
Automated code review of instrumentation/jmx-metrics/testing-apps/testing-webapp.
trask
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the two
testing-webappservlets to write directly to the container-managedHttpServletResponsewriter instead of closing it with try-with-resources. Mandatorymetadata.yamlvalidation also found an out-of-scope JMX config metadata gap.Applied Changes
General
File:
JakartaSimpleServlet.java:20Change: Replaced the try-with-resources block around
resp.getWriter()with a directresp.getWriter().write("hello!")call and removed the unusedPrintWriterimport.Reason: Repository review guidance prioritizes safe resource-handling fixes; container-managed servlet response writers should not be explicitly closed, and the simplified form matches existing servlet patterns in this repository.
File:
JavaxSimpleServlet.java:20Change: Replaced the try-with-resources block around
resp.getWriter()with a directresp.getWriter().write("hello!")call and removed the unusedPrintWriterimport.Reason: Repository review guidance prioritizes safe resource-handling fixes; container-managed servlet response writers should not be explicitly closed, and the simplified form matches existing servlet patterns in this repository.
Unresolved Items
File:
metadata.yamlReason: Mandatory
metadata.yamlvalidation found that the JMX module usesotel.jmx.enabled,otel.jmx.config,otel.jmx.target.system, andotel.jmx.discovery.delay, butmetadata.yamlcontains no corresponding config entries.Download code review diagnostics