Skip to content

Review fixes for testing-apps:testing-webapp #18119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Apr 21, 2026
Merged

Review fixes for testing-apps:testing-webapp #18119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...bapp/src/main/java/io/opentelemetry/instrumentation/jmx/testapp/JakartaSimpleServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;
import java.io.PrintWriter;

@WebServlet(urlPatterns = "/jakarta/*", name = "jakartaServlet")
public class JakartaSimpleServlet extends HttpServlet {
Expand All @@ -19,8 +18,6 @@ public class JakartaSimpleServlet extends HttpServlet {

@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
try (PrintWriter out = resp.getWriter()) {
out.write("hello!");
}
resp.getWriter().write("hello!");
}
}
5 changes: 1 addition & 4 deletions ...webapp/src/main/java/io/opentelemetry/instrumentation/jmx/testapp/JavaxSimpleServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
package io.opentelemetry.instrumentation.jmx.testapp;

import java.io.IOException;
import java.io.PrintWriter;
import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
Expand All @@ -19,8 +18,6 @@ public class JavaxSimpleServlet extends HttpServlet {

@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
try (PrintWriter out = resp.getWriter()) {
out.write("hello!");
}
resp.getWriter().write("hello!");
}
}
Loading