Skip to content

Use !cancelled() in required-status-check #18296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trask wants to merge 1 commit into from
Closed

Use !cancelled() in required-status-check #18296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,13 @@ jobs:
- muzzle
- markdown-lint-check
runs-on: ubuntu-latest
if: always()
# `!cancelled()` (instead of `always()`) makes this a "skipped" check-run
# when the workflow is cancelled by concurrency (e.g. when a "test *"
# label triggers a rebuild via rebuild-pull-request-on-label.yml). That
# avoids a noisy red "required-status-check failed" on the superseded
# run; the rebuild produces a same-named check that branch protection
# resolves to success.
if: ${{ !cancelled() }}
steps:
- if: |
needs.common.result != 'success' ||
Expand Down
Loading