Pin latest deps for all gradle configurations#18298
Merged
Merged
Conversation
trask
force-pushed
the
more-pinning
branch
4 times, most recently
from
294b01d to
9b1d5ef
Compare
trask
changed the title
trask
force-pushed
the
more-pinning
branch
3 times, most recently
from
19c9538 to
ebb2746
Compare
Broaden the testLatestDeps resolutionStrategy filter so that custom JvmTestSuite source sets (e.g. version5TestRuntimeClasspath in hibernate-4.0) and the main compileClasspath are also pinned via .github/config/latest-dep-versions.json. Latest-dep tests for those classpaths are now reproducible against the snapshot file rather than live Maven Central. Restrict latestDepTestLibrary overrides to the main test/latestDepTest configurations so that explicit older versions declared in custom JvmTestSuite source sets (e.g. play-mvc-2.4 play24Test, kubernetes-client-7.0 version20Test) are not overridden. Fail fast when a pinned version is missing for a latest.release or +-range lookup. Previously latest.release silently returned null and fell back to live Maven Central resolution; now it throws like the +-range case, with instructions to run resolveLatestDepVersions. Document the fail-fast behavior in docs/contributing/writing-instrumentation.md. GWT moved from com.google.gwt to org.gwtproject in 2.10.0. Use dependencySubstitution to rewrite the compileOnly gwt-user/gwt-dev coordinates in latest-deps mode, keep gwt-user and gwt-dev off the test classpath, and declare gwt-servlet directly with its post-2.10 coordinates so its JSON pin is reachable.
client-java-api 22.0.0 (and the latest.release used in latest-deps mode) requires Java 11+ (class file version 55), so the version22Test test task fails on the JDK 8 CI matrix with UnsupportedClassVersionError. Disable the task when testJavaVersion is Java 8.
# Conflicts: # .github/config/latest-dep-versions.json
# Conflicts: # instrumentation/kubernetes-client-7.0/javaagent/build.gradle.kts # instrumentation/pekko/pekko-http-1.0/javaagent/build.gradle.kts
The Play 2.4 custom test suite resolves Play Java, Java WS, and test artifacts with the 2.4.+ selector when testLatestDeps is enabled, but the latest-dependency pin file only contained pins for the 2.5.+ selectors. This caused CI dependency resolution to fail before running checkstyle. Add the missing 2.4.+ pins for the three Play 2.4 artifacts, using 2.4.11 as the latest Play 2.4 release. Validation: .\gradlew.bat :instrumentation:play:play-mvc:play-mvc-2.4:javaagent:checkstylePlay24Test -PtestLatestDeps=true
laurit
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently built on top of #18391