Code review sweep (run 24945510626)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• avaje-jex-3.0:javaagent
• aws-lambda-core-1.0:javaagent
• aws-lambda-core-1.0:library
• aws-lambda-core-1.0:testing
• aws-lambda-events-2.2:javaagent

---

Module: avaje-jex-3.0:javaagent

Module path: instrumentation/avaje-jex-3.0/javaagent

Summary

Removed an unnecessary @SuppressWarnings("unused") from JexInstrumentationModule; no other safe repository-guideline fixes were needed under instrumentation/avaje-jex-3.0/javaagent.

Applied Changes

Style

File: JexInstrumentationModule.java:15
Change: Removed the class-level `@SuppressWarnings("unused")` annotation from `JexInstrumentationModule`.
Reason: Repository `@SuppressWarnings` guidance prefers keeping suppressions only when they are actually needed; comparable `InstrumentationModule` classes do not require this unused suppression, so removing it avoids unnecessary annotation noise.

Module: aws-lambda-core-1.0:javaagent

Module path: instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent

Summary

Applied 2 safe review fixes under instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent: normalized the classLoaderMatcher() landmark-comment layout and narrowed one test throws clause. One metadata.yaml issue remains outside the requested directory scope.

Applied Changes

Javaagent

File: AwsLambdaInstrumentationModule.java:26
Change: Reformatted `classLoaderMatcher()` so each single-class `hasClassesNamed(...)` boundary comment sits in the canonical chained form above the relevant matcher call.
Reason: `javaagent-module-patterns.md` requires version-boundary comments on chained single-class `hasClassesNamed(...)` checks to be placed directly above the matcher call for clearer, consistent landmark detection.

Testing

File: AwsLambdaStreamHandlerTest.java:58
Change: Changed `handlerTraced()` from `throws Exception` to `throws IOException`.
Reason: `testing-general-patterns.md` says `@Test` methods should keep a single, as-specific-as-possible checked exception type instead of a broad `throws Exception`.

Unresolved Items

File: metadata.yaml
Reason: The `otel.instrumentation.aws-lambda.flush-timeout` entry still uses legacy metadata format: it is missing the required `declarative_name` (`java.aws_lambda.flush_timeout`) and uses `type: int` instead of the documented `integer`. Update the module `metadata.yaml` to match `metadata-yaml-format.md`; it was left unchanged because the requested review scope was limited to `instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent`.

Module: aws-lambda-core-1.0:library

Module path: instrumentation/aws-lambda/aws-lambda-core-1.0/library

Summary

Applied 4 safe review fixes in aws-lambda-core-1.0: added the missing declarative_name metadata mapping, aligned one static utility class with constructor-ordering rules, and narrowed two test throws clauses to IOException.

Applied Changes

Config

File: metadata.yaml:16
Change: Added `declarative_name: java.aws_lambda.flush_timeout` for `otel.instrumentation.aws-lambda.flush-timeout`.
Reason: `metadata-yaml-format.md` requires every `metadata.yaml` configuration entry to declare `declarative_name`, and this module already uses the matching config via `OTEL_INSTRUMENTATION_AWS_LAMBDA_FLUSH_TIMEOUT`.

Style

File: WrapperConfiguration.java:14
Change: Moved the private utility-class constructor to the end of `WrapperConfiguration`.
Reason: The style guide requires static utility classes to place the private constructor after all methods.

Testing

File: AwsLambdaStreamWrapperHttpPropagationTest.java:69
Change: Narrowed `handlerTraced()` from `throws Exception` to `throws IOException`.
Reason: The review checklist says `@Test` method `throws` clauses should be limited to a single exception type and kept as specific as possible.

File: AwsLambdaStreamWrapperTest.java:68
Change: Narrowed `handlerTraced()` from `throws Exception` to `throws IOException`.
Reason: The review checklist says `@Test` method `throws` clauses should be limited to a single exception type and kept as specific as possible.

Module: aws-lambda-core-1.0:testing

Module path: instrumentation/aws-lambda/aws-lambda-core-1.0/testing

Summary

Reviewed instrumentation/aws-lambda/aws-lambda-core-1.0/testing and applied no changes. The shared AbstractAwsLambdaTest visibility is required by cross-module test reuse, the in-scope test assertions already follow the repository testing guidance, and metadata.yaml matches the aws_lambda.flush_timeout config usage and default.

Applied Changes

No safe automated changes were applied.

Module: aws-lambda-events-2.2:javaagent

Module path: instrumentation/aws-lambda/aws-lambda-events-2.2/javaagent

Summary

Reviewed instrumentation/aws-lambda/aws-lambda-events-2.2/javaagent, applied 3 safe fixes, and completed the required Gradle validation for the module and updated metadata.yaml.

Applied Changes

Config

File: metadata.yaml:12
Change: Added missing `declarative_name` entries for `otel.instrumentation.aws-lambda.flush-timeout` and `otel.instrumentation.http.known-methods`.
Reason: `metadata-yaml-format.md` requires each instrumentation config entry to declare the correct declarative mapping, including the special mapping for `otel.instrumentation.http.known-methods`.

Style

File: AwsLambdaRequestHandlerInstrumentation.java:62
Change: Annotated the nullable SQS message state in `HandleRequestAdvice.AdviceScope` and its constructor parameters with `@Nullable`.
Reason: The nullability correctness rule requires fields and parameters that actually carry `null` on some paths to be explicitly annotated instead of treating nullable state as non-null.

Testing

File: AwsLambdaStreamHandlerTest.java:58
Change: Narrowed `handlerTraced()` from `throws Exception` to `throws IOException`.
Reason: `testing-general-patterns.md` says `@Test` methods should keep a single, most specific checked exception type instead of a broad `throws Exception`.

---

Download code review diagnostics