Code review sweep (run 24947827165)

instrumentation/aws-sdk/aws-sdk-1.11/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/autoconfigure/TracingRequestHandler.java

@@ -23,7 +23,7 @@
  */
 public final class TracingRequestHandler extends RequestHandler2 {
 
-  private static final RequestHandler2 DELEGATE = buildDelegate(GlobalOpenTelemetry.get());
+  private static final RequestHandler2 delegate = buildDelegate(GlobalOpenTelemetry.get());
 
   @SuppressWarnings("deprecation") // using deprecated config property
   private static RequestHandler2 buildDelegate(OpenTelemetry openTelemetry) {
@@ -56,21 +56,21 @@ private static RequestHandler2 buildDelegate(OpenTelemetry openTelemetry) {
 
   @Override
   public void beforeRequest(Request<?> request) {
-    DELEGATE.beforeRequest(request);
+    delegate.beforeRequest(request);
   }
 
   @Override
   public AmazonWebServiceRequest beforeMarshalling(AmazonWebServiceRequest request) {
-    return DELEGATE.beforeMarshalling(request);
+    return delegate.beforeMarshalling(request);
   }
 
   @Override
   public void afterResponse(Request<?> request, Response<?> response) {
-    DELEGATE.afterResponse(request, response);
+    delegate.afterResponse(request, response);
   }
 
   @Override
   public void afterError(Request<?> request, Response<?> response, Exception e) {
-    DELEGATE.afterError(request, response, e);
+    delegate.afterError(request, response, e);
   }
 }

instrumentation/aws-sdk/aws-sdk-1.11/library-autoconfigure/src/test/java/io/opentelemetry/instrumentation/awssdk/v1_11/instrumentor/SqsSuppressReceiveSpansTest.java

@@ -22,7 +22,7 @@ protected InstrumentationExtension testing() {
   }
 
   @Override
-  public AmazonSQSAsyncClientBuilder configureClient(AmazonSQSAsyncClientBuilder client) {
+  protected AmazonSQSAsyncClientBuilder configureClient(AmazonSQSAsyncClientBuilder client) {
     return client;
   }
 }

instrumentation/aws-sdk/aws-sdk-1.11/library-autoconfigure/src/test/java/io/opentelemetry/javaagent/instrumentation/awssdk/v1_11/SqsTracingTest.java

@@ -22,7 +22,7 @@ protected InstrumentationExtension testing() {
   }
 
   @Override
-  public AmazonSQSAsyncClientBuilder configureClient(AmazonSQSAsyncClientBuilder client) {
+  protected AmazonSQSAsyncClientBuilder configureClient(AmazonSQSAsyncClientBuilder client) {
     return client;
   }
 }

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractBaseAwsClientTest.java

@@ -77,7 +77,7 @@ public void assertRequestWithMockedResponse(
       String operation,
       String method,
       List<AttributeAssertion> additionalAttributes)
-      throws Exception {
+      throws ReflectiveOperationException {
 
     assertThat(response).isNotNull();
 
@@ -125,7 +125,8 @@ public void assertRequestWithMockedResponse(
   }
 
   @SuppressWarnings("unchecked")
-  protected List<RequestHandler2> extractRequestHandlers(Object client) throws Exception {
+  protected List<RequestHandler2> extractRequestHandlers(Object client)
+      throws ReflectiveOperationException {
     Field requestHandler2sField = AmazonWebServiceClient.class.getDeclaredField("requestHandler2s");
     requestHandler2sField.setAccessible(true);
     return (List<RequestHandler2>) requestHandler2sField.get(client);

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractDynamoDbClientTest.java

@@ -42,7 +42,7 @@ protected boolean hasRequestId() {
 
   @SuppressWarnings("deprecation") // using deprecated semconv
   @Test
-  void sendRequestWithMockedResponse() throws Exception {
+  void sendRequestWithMockedResponse() throws ReflectiveOperationException {
     AmazonDynamoDBClientBuilder clientBuilder = AmazonDynamoDBClientBuilder.standard();
     AmazonDynamoDB client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractEc2ClientTest.java

@@ -24,7 +24,7 @@ protected boolean hasRequestId() {
   }
 
   @Test
-  void sendRequestWithMockedResponse() throws Exception {
+  void sendRequestWithMockedResponse() throws ReflectiveOperationException {
     AmazonEC2ClientBuilder clientBuilder = AmazonEC2ClientBuilder.standard();
     AmazonEC2 client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractKinesisClientTest.java

@@ -35,7 +35,7 @@ protected boolean hasRequestId() {
   @ParameterizedTest
   @MethodSource("provideArguments")
   void testSendRequestWithMockedResponse(String operation, Function<AmazonKinesis, Object> call)
-      throws Exception {
+      throws ReflectiveOperationException {
     AmazonKinesisClientBuilder clientBuilder = AmazonKinesisClientBuilder.standard();
 
     AmazonKinesis client =

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractLambdaClientTest.java

@@ -172,7 +172,7 @@ void testSendRequestWithMockedResponse(
       String responseBody,
       List<AttributeAssertion> additionalAttributes,
       Function<AWSLambda, Object> call)
-      throws Exception {
+      throws ReflectiveOperationException {
     AWSLambdaClientBuilder clientBuilder = AWSLambdaClientBuilder.standard();
     AWSLambda client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractRdsClientTest.java

@@ -25,7 +25,7 @@ protected boolean hasRequestId() {
   }
 
   @Test
-  void sendRequestWithMockedResponse() throws Exception {
+  void sendRequestWithMockedResponse() throws ReflectiveOperationException {
     AmazonRDSClientBuilder clientBuilder = AmazonRDSClientBuilder.standard();
     AmazonRDS client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractS3ClientTest.java

@@ -64,7 +64,7 @@ void testSendRequestWithMockedResponse(
       String method,
       Function<AmazonS3, Object> call,
       List<AttributeAssertion> additionalAttributes)
-      throws Exception {
+      throws ReflectiveOperationException {
 
     AmazonS3 client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractSecretsManagerClientTest.java

@@ -31,7 +31,7 @@ protected boolean hasRequestId() {
   }
 
   @Test
-  void sendCreateSecretRequestWithMockedResponse() throws Exception {
+  void sendCreateSecretRequestWithMockedResponse() throws ReflectiveOperationException {
     AWSSecretsManagerClientBuilder clientBuilder = AWSSecretsManagerClientBuilder.standard();
     AWSSecretsManager client =
         configureClient(clientBuilder)
@@ -62,7 +62,7 @@ void sendCreateSecretRequestWithMockedResponse() throws Exception {
   }
 
   @Test
-  void sendDescribeSecretRequestWithMockedResponse() throws Exception {
+  void sendDescribeSecretRequestWithMockedResponse() throws ReflectiveOperationException {
     AWSSecretsManagerClientBuilder clientBuilder = AWSSecretsManagerClientBuilder.standard();
     AWSSecretsManager client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractSnsClientTest.java

@@ -61,7 +61,7 @@ void testSendRequestWithMockedResponse(
       String operation,
       String responseBody,
       List<AttributeAssertion> additionalAttributes)
-      throws Exception {
+      throws ReflectiveOperationException {
     AmazonSNSClientBuilder clientBuilder = AmazonSNSClientBuilder.standard();
     AmazonSNS client =
         configureClient(clientBuilder)

instrumentation/aws-sdk/aws-sdk-1.11/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AbstractStepFunctionsClientTest.java

@@ -41,7 +41,7 @@ void testSendRequestWithMockedResponse(
       String operation,
       List<AttributeAssertion> additionalAttributes,
       Function<AWSStepFunctions, Object> call)
-      throws Exception {
+      throws ReflectiveOperationException {
 
     AWSStepFunctionsClientBuilder clientBuilder = AWSStepFunctionsClientBuilder.standard();