Improve span naming when serving a resource (Wicket)#18312
Merged
Conversation
Requesting a page replaces the span name with the fully qualified class name of the Java page class. However, the same does not happen if the request hits a resource. In Wicket, a resource can serve things like class path resources, file paths, web context files, or anything else. This change applies the same span renaming as for pages by replacing it with the fully qualified class name of the Java ResourceReference. Instead of many spans named "GET /*" it will be split into for example; GET /com.company.resource.ProfilePicture GET /com.company.resource.RolesJSON GET /org.apache.wicket.request.resource.ContextRelativeResourceReference GET /org.apache.wicket.request.resource.PackageResourceReference GET /org.apache.wicket.resource.JQueryResourceReference
Member
|
/easycla |
Member
|
hi @asvanberg! let us know once you have signed the CLA, thanks |
Contributor
Author
I can't.
|
Member
|
ok, can you open an issue instead then? |
Contributor
Author
|
Managed to sign the CLA. @trask |
trask
approved these changes
Apr 30, 2026
Contributor
|
Thank you for your contribution @asvanberg! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting a page replaces the span name with the fully qualified class name of the Java page class. However, the same does not happen if the request hits a resource. In Wicket, a resource can serve things like class path resources, file paths, web context files, or anything else.
This change applies the same span renaming as for pages by replacing it with the fully qualified class name of the Java ResourceReference.
Instead of many spans named "GET /*" it will be split into for example;
GET /com.company.resource.ProfilePicture
GET /com.company.resource.RolesJSON
GET /org.apache.wicket.request.resource.ContextRelativeResourceReference
GET /org.apache.wicket.request.resource.PackageResourceReference
GET /org.apache.wicket.resource.JQueryResourceReference