Code review sweep (run 24966115874)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• hikaricp-3.0:javaagent
• hikaricp-3.0:library
• hikaricp-3.0:testing
• http-url-connection:javaagent
• hystrix-1.4:javaagent
• iceberg-1.8:library
• iceberg-1.8:testing
• influxdb-2.4:javaagent
• internal-application-logger:bootstrap
• internal-application-logger:javaagent
• internal-class-loader:compile-stub
• internal-class-loader:javaagent
• internal-class-loader:javaagent-integration-tests

---

Module: hikaricp-3.0:javaagent

Module path: instrumentation/hikaricp-3.0/javaagent

Summary

Reviewed all files under instrumentation/hikaricp-3.0/javaagent and found no safe repository-guideline fixes to apply; the scoped sources, tests, build.gradle.kts, and module metadata.yaml already match the loaded repository patterns.

Applied Changes

No safe automated changes were applied.

Module: hikaricp-3.0:library

Module path: instrumentation/hikaricp-3.0/library

Summary

Reviewed instrumentation/hikaricp-3.0/library and instrumentation/hikaricp-3.0/metadata.yaml; no safe repository-guideline fixes were needed.

Applied Changes

No safe automated changes were applied.

Module: hikaricp-3.0:testing

Module path: instrumentation/hikaricp-3.0/testing

Summary

Applied safe review fixes in instrumentation/hikaricp-3.0/testing by tightening field visibility and replacing the repeated instrumentation-name literal with a shared constant.

Applied Changes

Style

File: AbstractHikariInstrumentationTest.java:37
Change: Added `INSTRUMENTATION_NAME`, reused it in the metric assertions, and changed `cleanup` plus the `@Mock` fields to `private`.
Reason: The style guide requires minimal necessary visibility for fields, and `general-rules.md` plus the style guide prefer uppercase constant names for stable identifier values instead of repeating the same literal.

Module: http-url-connection:javaagent

Module path: instrumentation/http-url-connection/javaagent

Summary

No safe repository-guideline fixes were applied under instrumentation/http-url-connection/javaagent after reviewing the module source, tests, Gradle wiring, and required metadata.yaml coverage.

Applied Changes

No safe automated changes were applied.

Unresolved Items

File: metadata.yaml
Reason: `metadata-yaml-format.md` requires validating module config metadata, and `otel.instrumentation.common.peer-service-mapping` still has no `declarative_name`. The bridge already exposes this config as structured `java.common.service_peer_mapping`, but `DeclarativeConfigValidationTest` currently validates `type: map` entries only as scalar leaf values, so adding the declarative path here would need a broader metadata/validator update rather than a safe local fix.

Module: hystrix-1.4:javaagent

Module path: instrumentation/hystrix-1.4/javaagent

Summary

Reviewed instrumentation/hystrix-1.4/javaagent and applied one safe fix in instrumentation/hystrix-1.4/metadata.yaml to restore the required declarative config metadata for the Hystrix experimental flag.

Applied Changes

Config

File: metadata.yaml:5
Change: Added `declarative_name: java.hystrix.experimental_span_attributes/development` for `otel.instrumentation.hystrix.experimental-span-attributes`.
Reason: `knowledge/metadata-yaml-format.md` requires each instrumentation config entry to declare `declarative_name`, and its `experimental` flat property must map to a `/development` declarative path that matches the config key read by `HystrixSingletons`.

Module: iceberg-1.8:library

Module path: instrumentation/iceberg-1.8/library

Summary

Reviewed all files under instrumentation/iceberg-1.8/library and applied one safe fix: tightened IcebergMetricsReporter's internal helper visibility to match the repository's minimal-visibility rule. metadata.yaml needed no changes because the Iceberg module does not define module-specific config entries.

Applied Changes

Style

File: IcebergMetricsReporter.java:88
Change: Changed `reportScanMetrics(ScanReport)` from package-private to `private`.
Reason: The style guide requires the most restrictive access modifier that still allows the code to function; this helper is only called inside `IcebergMetricsReporter`, so package-private visibility was broader than necessary.

Module: iceberg-1.8:testing

Module path: instrumentation/iceberg-1.8/testing

Summary

Applied one safe review fix in instrumentation/iceberg-1.8/testing by correcting an inaccurate dependency comment in build.gradle.kts so it matches the actual Iceberg test support used by the module.

Applied Changes

General

File: build.gradle.kts:7
Change: Clarified the `iceberg-core` test-jar dependency comment to reference Iceberg test classes such as `TestTables` instead of the incorrect `TestTables`/`TestTable` wording.
Reason: The review checklist calls for fixing incorrect comments when the code usage is clear; this comment should accurately describe why the classified `iceberg-core` dependency is present.

Module: influxdb-2.4:javaagent

Module path: instrumentation/influxdb-2.4/javaagent

Summary

Applied 3 safe fixes in influxdb-2.4: aligned advice/scope nullability with actual ByteBuddy exit behavior and completed the module metadata.yaml config mapping.

Applied Changes

[Style]

File: InfluxDbImplInstrumentation.java:105
Change: Annotated `@Advice.Thrown` and nullable `@Advice.Enter` exit parameters with `@Nullable` in both advice classes.
Reason: The repository nullability rule requires `@Nullable` when `null` is a real runtime value; `@Advice.Thrown` is `null` on successful exits, and these `@Advice.Enter` values can also be `null` when enter advice returns `null`.

File: InfluxDbScope.java:31
Change: Annotated `InfluxDbScope.end(Throwable)` as `end(@nullable Throwable)`.
Reason: The repository nullability rule requires method signatures to reflect concrete null flows; `end()` is called with the advice `@Advice.Thrown` value, which is `null` on normal completion.

[Config]

File: metadata.yaml:8
Change: Added the missing `declarative_name: java.common.db.query_sanitization.enabled` for `otel.instrumentation.common.db.query-sanitization.enabled`.
Reason: `metadata-yaml-format.md` requires config entries to include `declarative_name`, and this property maps to the standard `java.common.db.query_sanitization.enabled` declarative key.

Module: internal-application-logger:bootstrap

Module path: instrumentation/internal/internal-application-logger/bootstrap

Summary

Reviewed all files under instrumentation/internal/internal-application-logger/bootstrap and applied 1 safe correctness fix. The module-level metadata.yaml has no config entries, and no additional safe repository-guideline fixes were needed in the other scoped files.

Applied Changes

General

File: ApplicationLoggerBridge.java:18
Change: Added `requireNonNull()` in `ApplicationLoggerBridge#set()` so a `null` bridge cannot silently satisfy `compareAndSet(null, bridge)` and leave bootstrap state unset.
Reason: Repository review rules prioritize real correctness fixes; rejecting invalid non-`@Nullable` input up front avoids a misleading later failure and keeps the bootstrap contract explicit.

Module: internal-application-logger:javaagent

Module path: instrumentation/internal/internal-application-logger/javaagent

Summary

Reviewed all files under instrumentation/internal/internal-application-logger/javaagent; the module code and metadata.yaml already match the applicable repository rules, so no safe deterministic fixes were applied.

Applied Changes

No safe automated changes were applied.

Module: internal-class-loader:compile-stub

Module path: instrumentation/internal/internal-class-loader/compile-stub

Summary

No safe fixes were applied. The only reviewable source in scope is under compile-stub/, and repository review rules explicitly treat compile-stub modules as stub modules that must not be modified.

Applied Changes

No safe automated changes were applied.

Module: internal-class-loader:javaagent

Module path: instrumentation/internal/internal-class-loader/javaagent

Summary

Reviewed instrumentation/internal/internal-class-loader/javaagent, validated the module metadata shape, and applied one safe test cleanup to align the JBoss test with the repository's JUnit exception-signature guidance.

Applied Changes

Testing

File: JbossClassloadingTest.java:26
Change: Changed the `@Test` method to declare a single checked exception type (`throws Exception`) and removed the now-unused `ModuleLoadException` import.
Reason: `testing-general-patterns.md` requires JUnit test entry points to use a single checked exception type instead of a multi-exception `throws` clause; here `Exception` is the narrowest single checked supertype covering both `ModuleLoadException` and `ClassNotFoundException`, and removing the unused import keeps the file formatting-clean.

Module: internal-class-loader:javaagent-integration-tests

Module path: instrumentation/internal/internal-class-loader/javaagent-integration-tests

Summary

Applied 1 safe review fix under instrumentation/internal/internal-class-loader/javaagent-integration-tests: ResourceInjectionTest now uses a plain local URLClassLoader instead of an unnecessary AtomicReference, and no other deterministic repository-guideline fixes were needed in scope.

Applied Changes

[Testing]

File: ResourceInjectionTest.java:32
Change: Replaced the local `AtomicReference<URLClassLoader>` with a plain `URLClassLoader`, updated the call sites, and removed the now-unneeded `@SuppressWarnings("UnnecessaryAsync")`.
Reason: The review checklist for test files favors direct, low-noise code; this concurrency wrapper was redundant in a single-threaded test and the suppression existed only to silence that non-idiomatic pattern.

---

Download code review diagnostics