Fix testLatestDeps#18324
Merged
Merged
Conversation
AfterAllCallback.afterAll() fires once per container the extension is registered in, including each @nested class (since static @RegisterExtension fields are inherited). This caused deferAfterAll cleanups to run as soon as the first nested container completed. Track the outermost container via beforeAll and only run deferAfterAll cleanups when afterAll fires on that same context. This was breaking ApacheHttpAsyncClientTest, where the shared async clients were closed after the first nested test class finished, causing all subsequent nested tests to fail with CancellationException.
jaydeluca
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-merged something bad just before the pinning PR got in 🤦♂️
AfterAllCallback.afterAll() fires once per container the extension is registered in, including each @nested class (since static @RegisterExtension fields are inherited). This caused deferAfterAll cleanups to run as soon as the first nested container completed.
Track the outermost container via beforeAll and only run deferAfterAll cleanups when afterAll fires on that same context.
This was breaking ApacheHttpAsyncClientTest, where the shared async clients were closed after the first nested test class finished, causing all subsequent nested tests to fail with CancellationException.