Code review sweep (run 25083201560)#18392
Merged
Merged
Conversation
Automated code review of instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagent.
Automated code review of instrumentation/spring/spring-boot-resources/javaagent.
Automated code review of instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-2.0/javaagent.
Automated code review of instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-webflux-4.3/testing.
Automated code review of instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-webmvc-4.3/javaagent.
Automated code review of instrumentation/spring/spring-data/spring-data-1.8/javaagent.
Automated code review of instrumentation/spring/spring-data/spring-data-3.0/kotlin-testing.
Automated code review of instrumentation/spring/spring-integration-4.1/library.
trask
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:
spring-boot-actuator-autoconfigure-2.0:javaagentspring:spring-boot-autoconfigurespring-boot-autoconfigure:testingspring-boot-resources:javaagentspring-boot-resources:javaagent-unit-testsspring-cloud-aws-3.0:javaagentspring-cloud-gateway-2.0:javaagentspring-cloud-gateway-2.2:testingspring-cloud-gateway-common:javaagentspring-cloud-gateway-common:testingspring-cloud-gateway-webflux-4.3:testingspring-cloud-gateway-webmvc-4.3:javaagentspring-core-2.0:javaagentspring-data-1.8:javaagentspring-data-3.0:kotlin-testingspring-data-3.0:testingspring-data-common:testingspring-integration-4.1:javaagentspring-integration-4.1:libraryModule:
spring-boot-actuator-autoconfigure-2.0:javaagentModule path:
instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagentSummary
Applied and committed 1 safe repository-guideline fix in
spring-boot-actuator-autoconfigure-2.0javaagent.Applied Changes
Build
File:
build.gradle.kts:11Change: Moved `assertInverse.set(true)` immediately after `versions.set(...)` in the `muzzle` `pass` block.
Reason: `gradle-conventions.md` requires `assertInverse.set(true)` to be inserted immediately after `versions.set(...)` unless `skip(...)` is present, without otherwise reordering the block.
Module:
spring:spring-boot-autoconfigureModule path:
instrumentation/spring/spring-boot-autoconfigureSummary
No safe repository-guideline fixes were applied under
instrumentation/spring/spring-boot-autoconfigure; review scans did not find deterministic low-risk issues requiring source changes.Applied Changes
No safe automated changes were applied.
Module:
spring-boot-autoconfigure:testingModule path:
instrumentation/spring/spring-boot-autoconfigure/testingSummary
Reviewed all files under
instrumentation/spring/spring-boot-autoconfigure/testing; no deterministic repository-guideline fixes were needed, so no source changes were applied.Applied Changes
No safe automated changes were applied.
Module:
spring-boot-resources:javaagentModule path:
instrumentation/spring/spring-boot-resources/javaagentSummary
Applied safe review fixes for
spring-boot-resourcesjavaagent and committed them in263eb715.Applied Changes
General
File:
SpringBootServiceNameDetector.java:40Change: Updated `COMMANDLINE_PATTERN` to capture non-whitespace `spring.application.name` values and aligned the detector Javadoc with the actual lookup order.
Reason: The review checklist requires fixing correctness issues and incorrect comments; the old regex rejected valid names such as `bullpen-2`, and the Javadoc described a stale lookup order.
Testing
File:
SpringBootServiceNameDetectorTest.java:135Change: Narrowed `yamlFileInCurrentDir(...)` from `throws Exception` to `throws IOException`, removed the broad `readString(...)` helper, and extended the command-line fallback test to cover a digit-containing service name.
Reason: `testing-general-patterns.md` requires `@Test` methods to use a single, specific checked exception where possible, and the added assertion coverage verifies the corrected command-line parsing behavior.
Module:
spring-boot-resources:javaagent-unit-testsModule path:
instrumentation/spring/spring-boot-resources/javaagent-unit-testsSummary
No safe repository-guideline fixes were needed under
instrumentation/spring/spring-boot-resources/javaagent-unit-tests. The modulemetadata.yamlcontains no instrumentation config entries requiring correction.Applied Changes
No safe automated changes were applied.
Module:
spring-cloud-aws-3.0:javaagentModule path:
instrumentation/spring/spring-cloud-aws-3.0/javaagentSummary
Reviewed 11 files under
instrumentation/spring/spring-cloud-aws-3.0/javaagentand the modulemetadata.yaml; no safe repository-guideline fixes were found to apply.Applied Changes
No safe automated changes were applied.
Module:
spring-cloud-gateway-2.0:javaagentModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-2.0/javaagentSummary
Applied and committed safe review fixes for
spring-cloud-gateway-2.0javaagent; one experimental-test-task issue remains because the review rules mark it as not safe to auto-fix.Applied Changes
Build
File:
build.gradle.kts:19Change: Changed the WebFlux muzzle `versions.set()` range to `"[4.3.0,)"` and replaced `tasks.withType<Test>().configureEach` with `tasks.test`.
Reason: `gradle-conventions.md` requires proper Maven range syntax for `muzzle` pass blocks and prefers `tasks.test` for modules with only the default test task; `latestDepTest` does not count as a second custom `Test` task.
Style
File:
GatewayTestApplication.java:16Change: Made `GatewayTestApplication` and its `@Bean` method package-private.
Reason: The style guide and testing guidance prefer minimal necessary visibility; test classes and test support code should avoid unnecessary `public` visibility.
Unresolved Items
File:
build.gradle.ktsReason: The default `test` task still enables experimental flags without a dedicated `testExperimental` task. The review instructions classify this as not safe to auto-fix; next action is to add a dedicated `testExperimental` task and gate assertions accordingly.
Module:
spring-cloud-gateway-2.2:testingModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-2.2/testingSummary
No safe repository-guideline fixes were applied in
spring-cloud-gateway-2.2/testing; the only issue found is report-only under the review rules.Applied Changes
No safe automated changes were applied.
Unresolved Items
File:
build.gradle.ktsReason: `otel.instrumentation.spring-cloud-gateway.experimental-span-attributes=true` is set in `tasks.withType<Test>().configureEach` without a dedicated `testExperimental` task; `testing-experimental-flags.md` says this should be isolated, but the review workflow marks missing `testExperimental` wiring as `do not auto-fix` because it can require broader assertion/task changes.
Module:
spring-cloud-gateway-common:javaagentModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/javaagentSummary
No safe repository-guideline fixes were needed under
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/javaagent; reviewedbuild.gradle.kts,GatewayRouteHelper.java, and the related Spring Cloud Gatewaymetadata.yamlconfiguration coverage.Applied Changes
No safe automated changes were applied.
Module:
spring-cloud-gateway-common:testingModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/testingSummary
No safe fixes were applied under
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/testing; the only deterministic-looking candidate changed shared test semantics and was reverted.Applied Changes
No safe automated changes were applied.
Unresolved Items
File:
AbstractRouteMappingTest.javaReason: The testing guideline prefers `hasAttributesSatisfyingExactly(...)`, but replacing the existing `hasAttributesSatisfying(...)` assertions requires enumerating standard HTTP/network span attributes that vary across dependent sibling modules, so this needs a broader manual assertion design rather than a safe local fix.
Module:
spring-cloud-gateway-webflux-4.3:testingModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-webflux-4.3/testingSummary
Applied 1 safe repository-guideline fix and committed it. One issue remains unresolved because the review rules explicitly say not to auto-fix missing
testExperimentaltask wiring.Applied Changes
Build
File:
build.gradle.kts:21Change: Changed `tasks.withType<Test>().configureEach` to `tasks.test` for JVM argument configuration.
Reason: `gradle-conventions.md` says single-test-task modules should use `tasks.test`; implicit `latestDepTest` does not count as an additional custom `Test` task.
Unresolved Items
File:
build.gradle.ktsReason: Experimental JVM flags are enabled on the default `test` task and no dedicated `testExperimental` task exists; review guidelines say missing `testExperimental` wiring should be reported, not auto-fixed. Next action: add canonical `testExperimental` task wiring and gate experimental assertions.
Module:
spring-cloud-gateway-webmvc-4.3:javaagentModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-webmvc-4.3/javaagentSummary
Applied and committed one safe repository-guideline fix for
spring-cloud-gateway-webmvc-4.3javaagent.Applied Changes
Build
File:
build.gradle.kts:29Change: Changed single-test-task JVM argument configuration from `tasks.withType<Test>().configureEach` to `tasks.test`.
Reason: `gradle-conventions.md` says single-test-task modules should use `tasks.test`; `latestDepTest` does not count as an additional custom `Test` task.
Unresolved Items
File:
GatewayWebMvcInstrumentationModule.javaReason: The Javaagent module guideline prefers compact single-class `hasClassesNamed(...)` landmark form, but applying that change failed `spotlessJavaCheck`; no safe source change was left for this item.
Module:
spring-core-2.0:javaagentModule path:
instrumentation/spring/spring-core-2.0/javaagentSummary
No safe repository-guideline fixes were needed for
instrumentation/spring/spring-core-2.0/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
spring-data-1.8:javaagentModule path:
instrumentation/spring/spring-data/spring-data-1.8/javaagentSummary
Applied and committed one safe review fix for
spring-data-1.8javaagent: normalized open-endedmuzzleversion ranges inbuild.gradle.kts.Applied Changes
Build
File:
build.gradle.kts:10Change: Changed `versions.set("[1.8.0.RELEASE,]")` and `versions.set("[1.2,]")` to Maven-style open-ended ranges using `)` as the upper bound delimiter.
Reason: `gradle-conventions.md` requires javaagent `muzzle` `versions.set(...)` values to use proper Maven ranges such as `[1.0,)`.
Module:
spring-data-3.0:kotlin-testingModule path:
instrumentation/spring/spring-data/spring-data-3.0/kotlin-testingSummary
Applied one safe repository-guideline fix in
spring-data-3.0/kotlin-testingand committed it.Applied Changes
Style
File:
KotlinSpringDataTest.kt:27Change: Changed companion-object `testing` `@RegisterExtension` field to `private`.
Reason: Repository style guide requires minimal necessary visibility and says static fields should be `private` unless they are constant-like fields.
Module:
spring-data-3.0:testingModule path:
instrumentation/spring/spring-data/spring-data-3.0/testingSummary
No safe repository-guideline fixes were applied under
instrumentation/spring/spring-data/spring-data-3.0/testing; reviewed files andmetadata.yamlshowed no deterministic issues in scope.Applied Changes
No safe automated changes were applied.
Module:
spring-data-common:testingModule path:
instrumentation/spring/spring-data/spring-data-common/testingSummary
No safe repository-guideline fixes were applied. Reviewed
instrumentation/spring/spring-data/spring-data-common/testing, skipped generatedbuild/artifacts, confirmed Spring Datametadata.yamlfiles have no config entries and no matching config usage, and found the source/helper patterns already aligned with the loaded review rules.Applied Changes
No safe automated changes were applied.
Module:
spring-integration-4.1:javaagentModule path:
instrumentation/spring/spring-integration-4.1/javaagentSummary
No safe repository-guideline fixes were found in
instrumentation/spring/spring-integration-4.1/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
spring-integration-4.1:libraryModule path:
instrumentation/spring/spring-integration-4.1/librarySummary
Applied and committed one safe repository-guideline fix for
spring-integration-4.1library.Applied Changes
Style
File:
TracingChannelInterceptor.java:36Change: Moved `directWithAttributesChannelClass`, `channelGetAttributeMh`, and their static initialization helpers into the class static-field section.
Reason: The repository style guide requires static fields to be placed before instance fields and methods, with helper methods for `static final` initialization allowed immediately after those fields.
Download code review diagnostics