Code review sweep (run 25084109220)#18393
Merged
Merged
Conversation
Automated code review of instrumentation/spring/spring-integration-4.1/testing.
Automated code review of instrumentation/spring/spring-jms/spring-jms-2.0/javaagent.
Automated code review of instrumentation/spring/spring-jms/spring-jms-2.0/testing.
Automated code review of instrumentation/spring/spring-jms/spring-jms-6.0/javaagent.
trask
approved these changes
Apr 29, 2026
Abstract test bases were made package-private in the prior review-fix commit, leaving no public/protected classes for javadoc to document, which fails the javadoc task. Other testing modules with the same issue (e.g., iceberg-1.8:testing) disable javadoc; do the same here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:
spring-integration-4.1:testingspring-jms-2.0:javaagentspring-jms-2.0:testingspring-jms-6.0:javaagentModule:
spring-integration-4.1:testingModule path:
instrumentation/spring/spring-integration-4.1/testingSummary
Applied safe visibility fixes in
spring-integration-4.1testing helpers and committed them as94654116.Applied Changes
Style
File:
AbstractComplexPropagationTest.java:36Change: Changed `AbstractComplexPropagationTest`, its constructor, and its `testing` field from public/protected visibility to package-private/private visibility.
Reason: The style guide requires minimal necessary visibility, and test classes should be package-private; sibling usages are same-package tests, so wider visibility was unnecessary.
File:
AbstractSpringCloudStreamProducerTest.java:15Change: Changed `AbstractSpringCloudStreamProducerTest`, its constructor, and its `testing` field from public/protected visibility to package-private/private visibility.
Reason: The style guide requires minimal necessary visibility, and test classes should be package-private; sibling usages are same-package tests, so wider visibility was unnecessary.
File:
AbstractSpringCloudStreamRabbitTest.java:13Change: Changed `AbstractSpringCloudStreamRabbitTest`, its constructor, and its `testing` field from public/protected visibility to package-private/private visibility.
Reason: The style guide requires minimal necessary visibility, and test classes should be package-private; sibling usages are same-package tests, so wider visibility was unnecessary.
File:
AbstractSpringIntegrationTracingTest.java:40Change: Changed the `testing` field from protected to private visibility.
Reason: The style guide requires minimal necessary visibility; the field is only used inside `AbstractSpringIntegrationTracingTest`.
File:
RabbitExtension.java:32Change: Changed `RabbitExtension`, its constructor, and `getBean(...)` from public visibility to package-private visibility.
Reason: The style guide requires minimal necessary visibility; repository sibling usage is limited to same-package tests and helpers.
Module:
spring-jms-2.0:javaagentModule path:
instrumentation/spring/spring-jms/spring-jms-2.0/javaagentSummary
Applied and committed two safe review fixes for
spring-jms-2.0javaagent.Applied Changes
Build
File:
build.gradle.kts:69Change: Added `metadataConfig` to the default `test` task for the non-default `otel.instrumentation.messaging.experimental.receive-telemetry.enabled=true` JVM mode.
Reason: `gradle-conventions.md` requires `metadataConfig` to describe non-default test configuration when metadata collection is present.
Style
File:
SpringTemplateTest.java:60Change: Renamed constant-like static final field `messageText` to `MESSAGE_TEXT` and updated usages.
Reason: The repository style guide requires `SCREAMING_SNAKE_CASE` for constant-like immutable value fields.
Module:
spring-jms-2.0:testingModule path:
instrumentation/spring/spring-jms/spring-jms-2.0/testingSummary
Applied one safe repository-guideline fix in
spring-jms-2.0:testingand committed it asa562ddc.Applied Changes
Style
File:
AbstractJmsTest.java:66Change: Added `@Nullable` to `assertConsumerSpan(...)` parameters `producer`, `parent`, and `msgId`, and to `consumerAttributeAssertions(...)` parameter `msgId`.
Reason: Repository nullability guidance requires `@Nullable` when callers concretely pass `null`; Spring JMS javaagent tests pass `null` for these helper parameters.
Module:
spring-jms-6.0:javaagentModule path:
instrumentation/spring/spring-jms/spring-jms-6.0/javaagentSummary
Applied safe repository-guideline fixes for
spring-jms-6.0javaagentand committed them inceec779a.Applied Changes
Build
File:
build.gradle.kts:25Change: Added sibling `testInstrumentation` for `:instrumentation:spring:spring-jms:spring-jms-2.0:javaagent` and added `metadataConfig` for the receive-telemetry test mode.
Reason: `gradle-conventions.md` requires javaagent version siblings to be listed via `testInstrumentation`, and existing non-default test JVM args must have matching `metadataConfig` when metadata collection is wired.
Testing
File:
AbstractSpringJmsListenerTest.java:60Change: Collapsed the `@ParameterizedTest` multi-exception `throws` clause to a single `throws Exception` and removed now-unused exception imports.
Reason: `testing-general-patterns.md` requires JUnit test entry points to use a single exception type; the timeout-based `CompletableFuture.get(...)` path exposes multiple checked exceptions without a cleaner narrow single type.
File:
SpringJmsListenerTest.java:86Change: Collapsed the `@ParameterizedTest` multi-exception `throws` clause to a single `throws Exception` and removed now-unused exception imports.
Reason: `testing-general-patterns.md` requires JUnit test entry points to use a single exception type; the timeout-based `CompletableFuture.get(...)` path exposes multiple checked exceptions without a cleaner narrow single type.
Download code review diagnostics