Code review sweep (run 25098914929)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• vibur-dbcp-11.0:library
• vibur-dbcp-11.0:testing
• wicket-8.0:common-testing
• wicket-8.0:javaagent
• wicket-8.0:wicket10-testing
• wicket-8.0:wicket8-testing
• xxl-job-1.9.2:javaagent
• xxl-job-2.1.2:javaagent
• xxl-job-2.3.0:javaagent
• xxl-job-common:javaagent
• xxl-job-common:testing
• zio-2.0:javaagent
• zio-http-3.0:javaagent

---

Module: vibur-dbcp-11.0:library

Module path: instrumentation/vibur-dbcp-11.0/library

Summary

No safe repository-guideline fixes were applied in instrumentation/vibur-dbcp-11.0/library. The in-scope source and Gradle files matched the loaded review rules, and the mandatory metadata.yaml review found no config entries or config reads to reconcile.

Applied Changes

No safe automated changes were applied.

Module: vibur-dbcp-11.0:testing

Module path: instrumentation/vibur-dbcp-11.0/testing

Summary

No safe fixes were applied under instrumentation/vibur-dbcp-11.0/testing; the only guideline issue found could not be fixed without violating another repository/testing rule or failing validation.

Applied Changes

No safe automated changes were applied.

Unresolved Items

File: AbstractViburInstrumentationTest.java
Reason: `shouldReportMetrics()` declares multiple checked exceptions, which conflicts with the testing guideline for `@Test` methods, but changing it to `throws Exception` fails Error Prone `InterruptedExceptionSwallowed`, and wrapping `SQLException` solely to narrow the throws clause is disallowed by `testing-general-patterns.md`.

Module: wicket-8.0:common-testing

Module path: instrumentation/wicket-8.0/common-testing

Summary

No safe repository-guideline fixes were needed under instrumentation/wicket-8.0/common-testing; the files already align with the loaded style, testing, and metadata.yaml review guidance.

Applied Changes

No safe automated changes were applied.

Module: wicket-8.0:javaagent

Module path: instrumentation/wicket-8.0/javaagent

Summary

No safe repository-guideline fixes were applied under instrumentation/wicket-8.0/javaagent; the scoped files and metadata.yaml were already consistent with the loaded review rules.

Applied Changes

No safe automated changes were applied.

Module: wicket-8.0:wicket10-testing

Module path: instrumentation/wicket-8.0/wicket10-testing

Summary

No safe repository-guideline fixes were found in instrumentation/wicket-8.0/wicket10-testing; no files were changed.

Applied Changes

No safe automated changes were applied.

Module: wicket-8.0:wicket8-testing

Module path: instrumentation/wicket-8.0/wicket8-testing

Summary

Applied and committed one safe repository-guideline fix in wicket8-testing: removed a redundant direct org.jsoup test dependency. Validation completed with :instrumentation:wicket-8.0:wicket8-testing:check, :instrumentation:wicket-8.0:wicket8-testing:check -PtestLatestDeps=true, and spotlessApply.

Applied Changes

Build

File: build.gradle.kts:9
Change: Removed redundant `testImplementation("org.jsoup:jsoup:1.13.1")`.
Reason: `gradle-conventions.md` flags unused or redundant Gradle dependencies; the scoped `WicketTest` does not reference `Jsoup`, and `:instrumentation:wicket-8.0:common-testing` already declares the dependency needed by `AbstractWicketTest`.

Module: xxl-job-1.9.2:javaagent

Module path: instrumentation/xxl-job/xxl-job-1.9.2/javaagent

Summary

Applied one safe repository-guideline cleanup in xxl-job-1.9.2 javaagent and committed it as 4afdefe1.

Applied Changes

Style

File: XxlJobSingletons.java:23
Change: Removed the redundant `object != null` guard before `object instanceof ReturnT`.
Reason: Java `instanceof` is already false for `null`; removing the dead condition follows the general review rule to clean up dead or redundant code safely.

Module: xxl-job-2.1.2:javaagent

Module path: instrumentation/xxl-job/xxl-job-2.1.2/javaagent

Summary

No safe repository-guideline fixes were found under instrumentation/xxl-job/xxl-job-2.1.2/javaagent. The related metadata.yaml entry matches the DeclarativeConfigUtil lookup and the module’s experimental test configuration.

Applied Changes

No safe automated changes were applied.

Module: xxl-job-2.3.0:javaagent

Module path: instrumentation/xxl-job/xxl-job-2.3.0/javaagent

Summary

Applied and committed safe style-guide fixes for xxl-job-2.3.0 javaagent test helpers; no unresolved issues remain.

Applied Changes

Style

File: XxlJobTest.java:33
Change: Replaced the static initializer for `groovyHandler` with `createGroovyHandler()` so all static fields remain grouped before methods.
Reason: Repository style guide class organization prefers static fields before static initializer/method sections; using a static factory preserves behavior while keeping fields grouped.

File: XxlJobTest.java:31
Change: Replaced the static initializer for `groovyHandler` with `createGroovyHandler()` so all static fields remain grouped before methods.
Reason: Repository style guide class organization prefers static fields before static initializer/method sections; using a static factory preserves behavior while keeping fields grouped.

File: ReflectiveMethodsFactory.java:13
Change: Moved `singletonObject`, static helper methods, private utility constructor, and nested `ReflectObject` into style-guide order.
Reason: Repository style guide class organization places static fields first, methods before a static utility class constructor, and nested classes last.

Module: xxl-job-common:javaagent

Module path: instrumentation/xxl-job/xxl-job-common/javaagent

Summary

No safe repository-guideline fixes were applied for instrumentation/xxl-job/xxl-job-common/javaagent; the reviewed files already matched the applicable style, javaagent, Gradle, shared-module, and metadata.yaml configuration guidelines.

Applied Changes

No safe automated changes were applied.

Module: xxl-job-common:testing

Module path: instrumentation/xxl-job/xxl-job-common/testing

Summary

Applied and committed safe repository-guideline fixes in xxl-job-common/testing.

Applied Changes

Style

File: ExperimentalTestHelper.java:11
Change: Renamed the cached experimental flag field from `isEnabled` to `EXPERIMENTAL_ATTRIBUTES`.
Reason: The style guide requires uppercase names for constant-like `static final` fields, and test guidance uses an `EXPERIMENTAL_ATTRIBUTES` flag for experimental attribute assertions.

File: ReflectiveMethodsFactory.java:13
Change: Moved the `singletonObject` field before methods, placed the utility constructor after methods, and kept nested `ReflectObject` last.
Reason: The style guide class organization rule orders static fields before methods and nested classes last; static utility constructors belong after utility methods.

File: XxlJobTestingConstants.java:49
Change: Moved the private utility constructor after the constant declarations.
Reason: The style guide says static utility class constructors should be placed after the utility members instead of before them.

Module: zio-2.0:javaagent

Module path: instrumentation/zio/zio-2.0/javaagent

Summary

Applied one safe repository-guideline fix under instrumentation/zio/zio-2.0/javaagent and committed it as 78de0fa2.

Applied Changes

Build

File: build.gradle.kts:36
Change: Changed `withType<Test>().configureEach` to `test` for the module JVM argument configuration.
Reason: `gradle-conventions.md` says single-test-task modules should prefer the simple `tasks.test` form; `latestDepTest` does not count as a second explicit test task and inherits `test` configuration.

Module: zio-http-3.0:javaagent

Module path: instrumentation/zio/zio-http-3.0/javaagent

Summary

Applied one safe repository-guideline fix under instrumentation/zio/zio-http-3.0/javaagent and committed it as 9b62560e.

Applied Changes

Style

File: RoutePatternInstrumentation.java:35
Change: Removed the unnecessary `final` modifier from nested advice class `CreateRouteAdvice`.
Reason: The repository style guide says classes under `javaagent/src/main/` are internal implementation details and should not be made `final` as public API classes.

---

Download code review diagnostics