Fix couchbase-3.1 instrumentation scope name behind v3 preview flag#18426
Merged
Conversation
laurit
approved these changes
Apr 30, 2026
laurit
reviewed
Apr 30, 2026
| public static void onExit(@Advice.This CoreEnvironment.Builder<?> builder) { | ||
| String instrumentationName = | ||
| SemconvStability.v3Preview() | ||
| ? "io.opentelemetry.couchbase-3.1" |
Contributor
There was a problem hiding this comment.
imo we could just change it and list it as a breaking change
Member
Author
There was a problem hiding this comment.
trying to see if we can be strict about telemetry stability for the Java agent
Member
Author
There was a problem hiding this comment.
oh, good point, I forgot that we could have treated this one as a bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #18421