Tracking package and module name alignment#18428
Draft
trask wants to merge 10 commits into
Draft
Conversation
trask
changed the title
trask
force-pushed
the
next
branch
2 times, most recently
from
89e469d to
de7e738
Compare
This was referenced May 12, 2026
This was referenced May 13, 2026
This was referenced May 13, 2026
This was referenced May 14, 2026
This was referenced May 18, 2026
trask
force-pushed
the
next
branch
3 times, most recently
from
e1491e9 to
caf14e4
Compare
This was referenced May 22, 2026
…t source sets Extracts a check_source_set function and runs it for both library and javaagent source roots. Previously only library/ was validated. This adds enforcement for javaagent module/package naming and produces explicit allow-lists for the historical exceptions and the no-base-version common modules.
PR 29 (oshi -> oshi-5.0) and PR 30 (elasticsearch-transport-common -> elasticsearch-transport-common-5.0) landed upstream together as open-telemetry#18854. Remove their now-stale unversioned-module allowlist entries from the checker and mark the corresponding plan sections as merged.
…mon} Their package layout already matches the module-name <-> package-name convention (jaxrs/v2_0/annotations, jaxrs/v2_0/common, jaxrs/v3_0/annotations, jaxrs/v3_0/common). Only the digit-suffix module-name guard fails because the version is embedded mid-name, so move them from the historical wildcard case to the no-base-version case where the package layout is still validated.
…open-telemetry#18855 PR 17 (akka-actor-fork-join-2.5 -> akka-actor-forkjoin-2.5 and scala-fork-join-2.8 -> scala-forkjoin-2.8) landed upstream as open-telemetry#18772. open-telemetry#18855 moved the servlet-common library internal package from io.opentelemetry.instrumentation.servlet.internal to io.opentelemetry.instrumentation.servlet.common.internal. Remove their now-stale checker carveouts and mark the corresponding plan sections as merged.
Keep the existing package layout for the four self-instrumentation modules (opentelemetry-api-1.0, opentelemetry-extension-annotations-1.0, opentelemetry-instrumentation-annotations-1.16, opentelemetry-instrumentation-api) instead of renaming them under .opentelemetry.* as PR 14 / open-telemetry#18747 proposed. Promote them in the checker from a generic historical wildcard to a dedicated self-instrumentation case block with a comment explaining why the standard module-name <-> package-name convention does not apply. The javaagent:opentelemetry-instrumentation-api unversioned-module allowlist entry was removed at the same time because the new case block already short-circuits before the unversioned check.
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.