Code review sweep (run 25149644494)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• http-url-connection:javaagent
• hystrix-1.4:javaagent
• iceberg-1.8:library
• iceberg-1.8:testing
• influxdb-2.4:javaagent
• internal-application-logger:bootstrap
• internal-application-logger:javaagent
• internal-class-loader:compile-stub
• internal-class-loader:javaagent
• internal-class-loader:javaagent-integration-tests

---

Module: http-url-connection:javaagent

Module path: instrumentation/http-url-connection/javaagent

Summary

Applied one safe review fix in http-url-connection javaagent tests and committed it.

Applied Changes

Testing

File: HttpUrlConnectionTest.java:161
Change: Replaced a no-argument `@ParameterizedTest` using `@ValueSource` with `@RepeatedTest(10)`.
Reason: JUnit `@ParameterizedTest` methods must consume supplied arguments; `@RepeatedTest` preserves the intended repeat behavior without invalid parameter resolution.

Module: hystrix-1.4:javaagent

Module path: instrumentation/hystrix-1.4/javaagent

Summary

Applied safe repository-guideline fixes in instrumentation/hystrix-1.4/javaagent and committed them in dbae8fa1.

Applied Changes

Testing

File: ExperimentalTestHelper.java:9
Change: Removed shared non-semconv `AttributeKey` test constants and renamed the experimental flag field to `EXPERIMENTAL_ATTRIBUTES`.
Reason: `testing-general-patterns.md` says non-semconv attribute keys in test `equalTo(...)` assertions should use inline `AttributeKey` factory methods, and flag-gated experimental assertions should use an `EXPERIMENTAL_ATTRIBUTES` constant-style flag.

File: HystrixObservableChainTest.java:96
Change: Replaced shared `HYSTRIX_*` test attribute constants with inline `stringKey(...)` and `booleanKey(...)` calls in `equalTo(...)` assertions.
Reason: `testing-general-patterns.md` reserves class-level test `AttributeKey` constants for semconv keys and requires inline factory methods for non-semconv keys in `equalTo(...)`.

File: HystrixObservableTest.java:86
Change: Replaced shared `HYSTRIX_*` test attribute constants with inline `stringKey(...)` and `booleanKey(...)` calls in `equalTo(...)` assertions.
Reason: `testing-general-patterns.md` reserves class-level test `AttributeKey` constants for semconv keys and requires inline factory methods for non-semconv keys in `equalTo(...)`.

File: HystrixTest.java:68
Change: Replaced shared `HYSTRIX_*` test attribute constants with inline `stringKey(...)` and `booleanKey(...)` calls in `equalTo(...)` assertions.
Reason: `testing-general-patterns.md` reserves class-level test `AttributeKey` constants for semconv keys and requires inline factory methods for non-semconv keys in `equalTo(...)`.

Module: iceberg-1.8:library

Module path: instrumentation/iceberg-1.8/library

Summary

Applied and committed one safe repository-guideline fix for instrumentation/iceberg-1.8/library.

Applied Changes

Style

File: IcebergTelemetry.java:22
Change: Added `requireNonNull` checks for the public entrypoint inputs used by `IcebergTelemetry`.
Reason: Repository style guidance says public APIs should defensively check non-`@Nullable` parameters for `null`.

Module: iceberg-1.8:testing

Module path: instrumentation/iceberg-1.8/testing

Summary

No safe repository-guideline fixes were applied under instrumentation/iceberg-1.8/testing; the reviewable build.gradle.kts and AbstractIcebergTest source already conform to the loaded style, testing, and metadata guidelines.

Applied Changes

No safe automated changes were applied.

Module: influxdb-2.4:javaagent

Module path: instrumentation/influxdb-2.4/javaagent

Summary

No safe repository-guideline fixes were applied for instrumentation/influxdb-2.4/javaagent; the reviewed files and metadata.yaml did not have deterministic in-scope issues that could be retained safely.

Applied Changes

No safe automated changes were applied.

Module: internal-application-logger:bootstrap

Module path: instrumentation/internal/internal-application-logger/bootstrap

Summary

Applied one safe repository-guideline fix in internal-application-logger bootstrap and committed it.

Applied Changes

Build

File: build.gradle.kts:5
Change: Removed the explicit `compileOnly(project(":javaagent-bootstrap"))` dependency from the `otel.javaagent-bootstrap` module.
Reason: `gradle-conventions.md` and the `otel.javaagent-bootstrap` convention plugin provide `:javaagent-bootstrap` automatically, so declaring it again is redundant dependency wiring.

Module: internal-application-logger:javaagent

Module path: instrumentation/internal/internal-application-logger/javaagent

Summary

Applied one safe Gradle convention fix in internal-application-logger javaagent and committed it as a2e234ba.

Applied Changes

Build

File: build.gradle.kts:24
Change: Removed the explicit `compileOnly(project(":javaagent-bootstrap"))` dependency.
Reason: `gradle-conventions.md` says javaagent modules must not declare `javaagent-bootstrap` explicitly because `otel.javaagent-instrumentation` already provides it transitively.

Unresolved Items

File: build.gradle.kts
Reason: The Spring Boot muzzle `pass` block still lacks `assertInverse.set(true)`, but adding it made `:instrumentation:internal:internal-application-logger:javaagent:muzzle` fail because pre-`1.2.0` Spring Boot versions unexpectedly pass muzzle; a safe fix would require an intentional version-boundary design, not an automatic review edit.

Module: internal-class-loader:compile-stub

Module path: instrumentation/internal/internal-class-loader/compile-stub

Summary

No safe fixes were applied. The requested target is under compile-stub/, and the review guideline says stub modules must be skipped because their API shape must match the external class; parent metadata.yaml has no config entries or config usage requiring updates.

Applied Changes

No safe automated changes were applied.

Module: internal-class-loader:javaagent

Module path: instrumentation/internal/internal-class-loader/javaagent

Summary

Applied 1 safe repository-guideline fix and committed it in 4cea6a7c.

Applied Changes

Build

File: build.gradle.kts:8
Change: Removed the explicit `compileOnly(project(":javaagent-bootstrap"))` dependency.
Reason: `gradle-conventions.md` says javaagent modules must not declare `javaagent-bootstrap` explicitly because `otel.javaagent-instrumentation` already provides it on the `compileOnly` classpath.

Module: internal-class-loader:javaagent-integration-tests

Module path: instrumentation/internal/internal-class-loader/javaagent-integration-tests

Summary

Applied and committed one safe repository-guideline fix in javaagent-integration-tests: removed a redundant type-level classloader optimization from a name-only matcher.

Applied Changes

Javaagent

File: TestInstrumentationModule.java:44
Change: Removed `classLoaderOptimization()` and the now-unused `hasClassesNamed` import from `TestTypeInstrumentation`.
Reason: `javaagent-module-patterns.md` says `classLoaderOptimization()` is only needed for expensive hierarchy or annotation matchers; `typeMatcher()` uses a cheap `named(...)` matcher, so the extra optimization is redundant.

---

Download code review diagnostics