Code review sweep (run 25156701996)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• jaxrs-2.0-resteasy-3.1:javaagent
• jaxrs-2.0-resteasy-common-3.0:javaagent
• jaxrs-2.0:jaxrs-2.0-tomee-testing
• jaxrs-2.0:jaxrs-2.0-wildfly-testing
• jaxrs-3.0-annotations:javaagent
• jaxrs-3.0-common:javaagent
• jaxrs-3.0-common:testing
• jaxrs-3.0-jersey-3.0:javaagent
• jaxrs-3.0-resteasy-6.0:javaagent

---

Module: jaxrs-2.0-resteasy-3.1:javaagent

Module path: instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.1/javaagent

Summary

Applied and committed safe review fixes for jaxrs-2.0-resteasy-3.1 javaagent: corrected a classLoaderMatcher() landmark comment and standardized experimental flag reads in tests.

Applied Changes

Javaagent

File: Resteasy31InstrumentationModule.java:30
Change: Corrected the `javax.ws.rs.Path` landmark comment to document that it was added in `javax.ws.rs:javax.ws.rs-api` `1.0` and removed in `3.0` when renamed to `jakarta.ws.rs.Path`.
Reason: `javaagent-module-patterns.md` requires validated version comments on `hasClassesNamed()` landmark classes, including the class role and version boundary.

Testing

File: ResteasyHttpServerTest.java:19
Change: Hoisted the `otel.instrumentation.jaxrs.experimental-span-attributes` read into a per-class `EXPERIMENTAL_ATTRIBUTES` constant and returned that from `testExperimental()`.
Reason: `testing-experimental-flags.md` says experimental instrumentation flags should be read once into a per-class constant instead of using inline `Boolean.getBoolean(...)` calls.

File: ResteasyJettyHttpServerTest.java:15
Change: Hoisted the `otel.instrumentation.jaxrs.experimental-span-attributes` read into a per-class `EXPERIMENTAL_ATTRIBUTES` constant and returned that from `testExperimental()`.
Reason: `testing-experimental-flags.md` says experimental instrumentation flags should be read once into a per-class constant instead of using inline `Boolean.getBoolean(...)` calls.

Unresolved Items

File: build.gradle.kts
Reason: Adding `assertInverse.set(true)` to the RESTEasy `muzzle` `pass` blocks matches the general Gradle convention, but the attempted fix made `./gradlew :instrumentation:jaxrs:jaxrs-2.0:jaxrs-2.0-resteasy-3.1:javaagent:muzzle` fail during configuration with duplicate `muzzle-AssertFail-org.jboss.resteasy-resteasy-jaxrs-3.0.19.Final`; resolving that requires a manual muzzle wiring decision.

Module: jaxrs-2.0-resteasy-common-3.0:javaagent

Module path: instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common-3.0/javaagent

Summary

Applied and committed one safe review fix for jaxrs-2.0-resteasy-common-3.0 javaagent.

Applied Changes

Nullability

File: ResteasySpanName.java:28
Change: Updated `ResteasySpanName.get(...)` to annotate the `name` parameter with `@Nullable` and return `null` when `name` is `null`.
Reason: `HttpServerRouteGetter.get(Context, @nullable T)` allows a nullable argument, and repository nullability guidance requires overrides to match concrete upstream nullable contracts and handle null safely.

Module: jaxrs-2.0:jaxrs-2.0-tomee-testing

Module path: instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-tomee-testing

Summary

Applied 1 safe repository-guideline fix under instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-tomee-testing; 1 item remains for manual follow-up.

Applied Changes

Build

File: build.gradle.kts:22
Change: Replaced `tasks.withType<Test>().configureEach` with `tasks.test` for the module JVM args.
Reason: `gradle-conventions.md` says single-test-task modules should use `tasks.test`; implicit `latestDepTest` does not count as a second explicit `Test` task.

Unresolved Items

File: build.gradle.kts
Reason: `tasks.test` still enables `-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true` without a dedicated `testExperimental` task; the review workflow says not to auto-fix missing `testExperimental` tasks, so this needs a manual task-wiring and assertion-gating decision.

Module: jaxrs-2.0:jaxrs-2.0-wildfly-testing

Module path: instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-wildfly-testing

Summary

Applied one safe repository-guideline fix and committed it as f1d1ba60; one experimental-test-task wiring item remains unresolved because the review workflow marks it as non-autofixable.

Applied Changes

Build

File: build.gradle.kts:54
Change: Moved the default test JVM args from `tasks.withType<Test>().configureEach` into the existing `test {}` block.
Reason: `gradle-conventions.md` says single-test-task modules should prefer the simple `tasks.test`/`test {}` form; `withType<Test>().configureEach` is justified only when the module explicitly registers additional `Test` tasks, and `latestDepTest` does not count.

Unresolved Items

File: build.gradle.kts
Reason: `-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true` is still enabled on the default `test` task. The review workflow classifies missing dedicated `testExperimental` task wiring for unconditional experimental flags as non-autofixable; next action is to decide whether this module should split flag-on coverage into `testExperimental` or intentionally keep this specialized suite flag-on.

Module: jaxrs-3.0-annotations:javaagent

Module path: instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-annotations/javaagent

Summary

Applied and committed one safe repository-guideline fix for jaxrs-3.0-annotations javaagent.

Applied Changes

Build

File: build.gradle.kts:27
Change: Changed the test configuration from `withType<Test>().configureEach { ... }` to `test { ... }`.
Reason: `gradle-conventions.md` says single-test-task modules should use the simple `test { ... }` form; `withType<Test>().configureEach` is reserved for modules that explicitly register additional `Test` tasks.

Module: jaxrs-3.0-common:javaagent

Module path: instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-common/javaagent

Summary

No safe repository-guideline fixes were applied under instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-common/javaagent; scoped source and build.gradle.kts files already match the applicable review rules, and generated/binary build/ outputs were skipped as non-reviewable.

Applied Changes

No safe automated changes were applied.

Module: jaxrs-3.0-common:testing

Module path: instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-common/testing

Summary

Reviewed all files under instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-common/testing; no safe repository-guideline fixes were found, so no source changes were applied.

Applied Changes

No safe automated changes were applied.

Module: jaxrs-3.0-jersey-3.0:javaagent

Module path: instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-jersey-3.0/javaagent

Summary

Applied safe review fixes and committed them in e5afac37 (Review fixes for jaxrs-3.0-jersey-3.0 javaagent).

Applied Changes

Testing

File: JerseyHttpServerTest.java:23
Change: Added `EXPERIMENTAL_ATTRIBUTES` and changed `testExperimental()` to return the constant instead of calling `Boolean.getBoolean(...)` inline.
Reason: `testing-general-patterns.md` requires flag-gated test assertions to read experimental flags through a per-class `EXPERIMENTAL_ATTRIBUTES` constant instead of duplicating the property string inline.

File: JerseyJettyHttpServerTest.java:15
Change: Added `EXPERIMENTAL_ATTRIBUTES` and changed `testExperimental()` to return the constant instead of calling `Boolean.getBoolean(...)` inline.
Reason: `testing-general-patterns.md` requires flag-gated test assertions to read experimental flags through a per-class `EXPERIMENTAL_ATTRIBUTES` constant instead of duplicating the property string inline.

Module: jaxrs-3.0-resteasy-6.0:javaagent

Module path: instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-resteasy-6.0/javaagent

Summary

Applied and committed safe review fixes for jaxrs-3.0-resteasy-6.0 javaagent tests.

Applied Changes

Testing

File: ResteasyHttpServerTest.java:19
Change: Added a per-class `EXPERIMENTAL_ATTRIBUTES` constant and made `testExperimental()` return it.
Reason: `testing-general-patterns.md` says experimental flags should be read through a shared per-class constant instead of inline `Boolean.getBoolean(...)` calls.

File: ResteasyJettyHttpServerTest.java:15
Change: Added a per-class `EXPERIMENTAL_ATTRIBUTES` constant and made `testExperimental()` return it.
Reason: `testing-general-patterns.md` says experimental flags should be read through a shared per-class constant instead of inline `Boolean.getBoolean(...)` calls.

---

Download code review diagnostics