Code review sweep (run 25176007766)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• jaxrs-common:bootstrap
• jaxrs-common:javaagent
• jaxrs-common:testing
• jaxws:jaxws-2.0-arquillian-testing
• jaxws-2.0-axis2-1.6:javaagent
• jaxws:jaxws-2.0-common-testing
• jaxws:jaxws-2.0-tomee-testing
• jaxws:jaxws-2.0-wildfly-testing
• jaxws-2.0:javaagent
• jaxws:jaxws-3.0-axis2-2.0-testing
• jaxws:jaxws-3.0-common-testing
• jaxws:jaxws-3.0-cxf-4.0-testing
• jaxws:jaxws-3.0-metro-3.0-testing
• jaxws-common:javaagent

---

Module: jaxrs-common:bootstrap

Module path: instrumentation/jaxrs/jaxrs-common/bootstrap

Summary

No safe repository-guideline fixes were found in instrumentation/jaxrs/jaxrs-common/bootstrap; no files were changed.

Applied Changes

No safe automated changes were applied.

Module: jaxrs-common:javaagent

Module path: instrumentation/jaxrs/jaxrs-common/javaagent

Summary

Applied and committed safe nullability contract fixes for jaxrs-common javaagent; no unresolved review items remain.

Applied Changes

Nullability

File: HandlerData.java:123
Change: Annotated `buildSpanName` parameters with `@Nullable`.
Reason: `buildSpanName` is called with values from nullable path lookup branches and already handles `null`; the repository nullability rule requires parameters that can receive `null` to be annotated accurately.

File: JaxrsPathUtil.java:11
Change: Annotated `normalizePath` parameter with `@Nullable`.
Reason: `normalizePath` explicitly accepts and normalizes `null`, including calls from JAX-RS route data that may be absent; the repository nullability rule requires parameters that can receive `null` to be annotated accurately.

Module: jaxrs-common:testing

Module path: instrumentation/jaxrs/jaxrs-common/testing

Summary

No safe repository-guideline fixes were applied under instrumentation/jaxrs/jaxrs-common/testing. The review found no deterministic issues in scope; the only visibility candidate, TestResponse(String, int), must remain public because sibling test subclasses in other packages instantiate it.

Applied Changes

No safe automated changes were applied.

Module: jaxws:jaxws-2.0-arquillian-testing

Module path: instrumentation/jaxws/jaxws-2.0-arquillian-testing

Summary

No safe repository-guideline fixes were found under instrumentation/jaxws/jaxws-2.0-arquillian-testing; no files were changed.

Applied Changes

No safe automated changes were applied.

Module: jaxws-2.0-axis2-1.6:javaagent

Module path: instrumentation/jaxws/jaxws-2.0-axis2-1.6/javaagent

Summary

Applied one safe repository-guideline fix under instrumentation/jaxws/jaxws-2.0-axis2-1.6/javaagent and committed it as 2006e4ce.

Applied Changes

Build

File: build.gradle.kts:57
Change: Changed the single test-task configuration from `tasks.withType<Test>().configureEach` to `tasks.test`.
Reason: `gradle-conventions.md` says modules with only the default `Test` task should use `tasks.test`; implicit `latestDepTest` does not justify `withType<Test>().configureEach`.

Module: jaxws:jaxws-2.0-common-testing

Module path: instrumentation/jaxws/jaxws-2.0-common-testing

Summary

No safe repository-guideline fixes were applied under instrumentation/jaxws/jaxws-2.0-common-testing; the tracked files already conformed to the loaded review rules, and the module has no scoped metadata.yaml or config entries to fix.

Applied Changes

No safe automated changes were applied.

Module: jaxws:jaxws-2.0-tomee-testing

Module path: instrumentation/jaxws/jaxws-2.0-tomee-testing

Summary

Applied one safe repository-guideline fix and committed it as 0a3bd113 (Review fixes for jaxws-2.0-tomee-testing).

Applied Changes

Build

File: build.gradle.kts:24
Change: Changed `tasks.withType<Test>().configureEach { ... }` to `tasks.test { ... }`.
Reason: `gradle-conventions.md` says single-test-task modules should prefer `tasks.test { ... }`; `withType<Test>().configureEach` is for modules that explicitly register additional `Test` tasks.

Module: jaxws:jaxws-2.0-wildfly-testing

Module path: instrumentation/jaxws/jaxws-2.0-wildfly-testing

Summary

Applied one safe review fix under instrumentation/jaxws/jaxws-2.0-wildfly-testing and committed it as 4f3d09e9.

Applied Changes

Build

File: build.gradle.kts:57
Change: Moved the shared `jvmArgs(...)` calls from `tasks.withType<Test>().configureEach` into the existing `test { ... }` task configuration.
Reason: `gradle-conventions.md` says single-test-task modules should prefer `tasks.test { ... }`; `withType<Test>().configureEach` is only justified when the same `build.gradle.kts` registers additional custom `Test` tasks.

Module: jaxws-2.0:javaagent

Module path: instrumentation/jaxws/jaxws-2.0/javaagent

Summary

Applied 1 safe repository-guideline fix and committed it in d6d30077.

Applied Changes

Build

File: build.gradle.kts:19
Change: Changed the single test-task configuration from `tasks.withType<Test>().configureEach` to `tasks.test`.
Reason: `gradle-conventions.md` says modules without explicitly registered custom `Test` tasks should use the simple `tasks.test` form; `latestDepTest` does not count as a second test task, and `collectMetadata` should not use `withType<Test>().configureEach` in single-test-task modules.

Module: jaxws:jaxws-3.0-axis2-2.0-testing

Module path: instrumentation/jaxws/jaxws-3.0-axis2-2.0-testing

Summary

Applied one safe build-convention fix in jaxws-3.0-axis2-2.0-testing; left the testExperimental split as unresolved because it changes test behavior and the review instructions say not to auto-fix that case.

Applied Changes

Build

File: build.gradle.kts:25
Change: Replaced `tasks.withType<Test>().configureEach` with `tasks.test` for the module JVM argument configuration.
Reason: `gradle-conventions.md` says single-test-task modules should prefer `tasks.test`; implicit `latestDepTest` does not count as a second custom `Test` task.

Unresolved Items

File: build.gradle.kts
Reason: The experimental flag `-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true` is enabled on the default `test` task without a dedicated `testExperimental` task; review instructions classify this as report-only because isolating it would require behavior-changing test assertion/task restructuring.

Module: jaxws:jaxws-3.0-common-testing

Module path: instrumentation/jaxws/jaxws-3.0-common-testing

Summary

No safe repository-guideline fixes were applied in instrumentation/jaxws/jaxws-3.0-common-testing; reviewed source-owned files and nearby JAX-WS metadata.yaml config mapping without finding deterministic issues.

Applied Changes

No safe automated changes were applied.

Module: jaxws:jaxws-3.0-cxf-4.0-testing

Module path: instrumentation/jaxws/jaxws-3.0-cxf-4.0-testing

Summary

Applied one safe Gradle-convention fix in jaxws-3.0-cxf-4.0-testing; one report-only experimental test-task issue remains.

Applied Changes

Build

File: build.gradle.kts:22
Change: Changed `tasks.withType<Test>().configureEach` to `tasks.test` for the module JVM argument configuration.
Reason: `gradle-conventions.md` says single-test-task modules should prefer `tasks.test`; `withType<Test>().configureEach` is reserved for modules with explicit additional `Test` tasks, and `latestDepTest` does not count.

Unresolved Items

File: build.gradle.kts
Reason: The experimental flag `otel.instrumentation.common.experimental.controller-telemetry.enabled=true` still runs on the default `test` task without a dedicated `testExperimental` task; the review instructions classify missing `testExperimental` wiring as report-only rather than an auto-fix. Next action: add a dedicated `testExperimental` task and gate assertions if the module should also exercise flag-off behavior.

Module: jaxws:jaxws-3.0-metro-3.0-testing

Module path: instrumentation/jaxws/jaxws-3.0-metro-3.0-testing

Summary

Applied 1 safe Gradle convention fix in jaxws-3.0-metro-3.0-testing and committed it. One testExperimental wiring concern remains manual-only per review instructions.

Applied Changes

Build

File: build.gradle.kts:21
Change: Changed `tasks.withType<Test>().configureEach` to `tasks.test`.
Reason: `gradle-conventions.md` says single-test-task modules should use the simple `tasks.test` form; `latestDepTest` does not count as a second custom test task.

Unresolved Items

File: build.gradle.kts
Reason: The default `test` task still enables `-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true` without a dedicated `testExperimental` task. The review instructions classify missing `testExperimental` wiring for unconditional experimental flags as non-auto-fixable, so this needs an intentional manual change.

Module: jaxws-common:javaagent

Module path: instrumentation/jaxws/jaxws-common/javaagent

Summary

Applied 1 safe repository-guideline fix under instrumentation/jaxws/jaxws-common/javaagent and committed it as c8ce8d93.

Applied Changes

Style

File: JaxWsCodeAttributesGetter.java:10
Change: Removed the class-level `final` modifier from `JaxWsCodeAttributesGetter`.
Reason: The repository style guide says classes under `javaagent/src/main/` are internal implementation details and should not use class-level `final` for public-API finalization conventions.

---

Download code review diagnostics