Code review sweep (run 25185529106)#18460
Merged
Merged
Conversation
Automated code review of instrumentation/jms/jms-common-1.1/javaagent.
Automated code review of instrumentation/jsf/jsf-mojarra-1.2/javaagent.
Automated code review of instrumentation/jsf/jsf-mojarra-3.0/javaagent.
Automated code review of instrumentation/jsf/jsf-myfaces-1.2/javaagent.
Automated code review of instrumentation/jsf/jsf-myfaces-3.0/javaagent.
Automated code review of instrumentation/jsp-2.3/javaagent.
Automated code review of instrumentation/kafka/kafka-clients/kafka-clients-0.11/bootstrap.
The preceding commit renamed setEnabled -> setWrappingEnabled but missed callers in reactor-kafka-1.0, spring-kafka-2.7, and vertx-kafka-client-3.6.
trask
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:
hibernate-common-3.3:javaagentjedis-common-1.4:javaagentjms-common-1.1:bootstrapjms-common-1.1:javaagentjms-common-1.1:javaagent-unit-testsjodd-http-4.2:javaagent-unit-testsjsf-common-jakarta:javaagentjsf-common-jakarta:testingjsf-common-javax:javaagentjsf-common-javax:testingjsf-mojarra-1.2:javaagentjsf-mojarra-3.0:javaagentjsf-myfaces-1.2:javaagentjsf-myfaces-3.0:javaagentjsp-2.3:javaagentkafka-clients-0.11:bootstrapModule:
hibernate-common-3.3:javaagentModule path:
instrumentation/hibernate/hibernate-common-3.3/javaagentSummary
No safe repository-guideline fixes were applied after reviewing all files under
instrumentation/hibernate/hibernate-common-3.3/javaagent; the sharedhibernateconfig is covered by the versionedmetadata.yamlfiles and the common public helper types are used from sibling javaagent packages.Applied Changes
No safe automated changes were applied.
Module:
jedis-common-1.4:javaagentModule path:
instrumentation/jedis/jedis-common-1.4/javaagentSummary
No safe repository-guideline fixes were found in
instrumentation/jedis/jedis-common-1.4/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
jms-common-1.1:bootstrapModule path:
instrumentation/jms/jms-common-1.1/bootstrapSummary
No safe repository-guideline fixes were applied after reviewing
instrumentation/jms/jms-common-1.1/bootstrap; the scopedbuild.gradle.ktsandJmsReceiveContextHolderalready conform to the loaded style, Gradle, nullability, and mandatory metadata review guidance.Applied Changes
No safe automated changes were applied.
Module:
jms-common-1.1:javaagentModule path:
instrumentation/jms/jms-common-1.1/javaagentSummary
Applied safe repository-guideline fixes for
instrumentation/jms/jms-common-1.1/javaagentand committed them in77ec78c9.Applied Changes
Style
File:
JmsInstrumenterFactory.java:58Change: Replaced `MessagePropertySetter.INSTANCE` with `new MessagePropertySetter()` when building the producer instrumenter.
Reason: Repository singleton guidance prefers direct instance creation for stateless telemetry interface implementations such as `TextMapSetter` when used during instrumenter initialization.
File:
MessagePropertySetter.java:14Change: Converted `MessagePropertySetter` from an enum singleton to a package-private class.
Reason: Repository singleton guidance says stateless `TextMapSetter` implementations should not use enum or `INSTANCE` singleton patterns unless needed on a hot path.
Module:
jms-common-1.1:javaagent-unit-testsModule path:
instrumentation/jms/jms-common-1.1/javaagent-unit-testsSummary
No safe repository-guideline fixes were applied under
instrumentation/jms/jms-common-1.1/javaagent-unit-tests; reviewed scoped files and mandatory JMSmetadata.yamlentries without finding deterministic issues.Applied Changes
No safe automated changes were applied.
Module:
jodd-http-4.2:javaagent-unit-testsModule path:
instrumentation/jodd-http-4.2/javaagent-unit-testsSummary
No safe repository-guideline fixes were found in
instrumentation/jodd-http-4.2/javaagent-unit-tests; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
jsf-common-jakarta:javaagentModule path:
instrumentation/jsf/jsf-common-jakarta/javaagentSummary
No safe repository-guideline fixes were found in
instrumentation/jsf/jsf-common-jakarta/javaagent;metadata.yamlcoverage for the related Jakarta JSF modules already matches the common experimental controller telemetry config.Applied Changes
No safe automated changes were applied.
Module:
jsf-common-jakarta:testingModule path:
instrumentation/jsf/jsf-common-jakarta/testingSummary
No safe repository-guideline fixes were identified in
instrumentation/jsf/jsf-common-jakarta/testing; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
jsf-common-javax:javaagentModule path:
instrumentation/jsf/jsf-common-javax/javaagentSummary
No safe repository-guideline fixes were found in
instrumentation/jsf/jsf-common-javax/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
jsf-common-javax:testingModule path:
instrumentation/jsf/jsf-common-javax/testingSummary
No safe in-scope fixes were applied after reviewing
instrumentation/jsf/jsf-common-javax/testing; the target files matched the loaded style, testing, and Gradle guidelines.Applied Changes
No safe automated changes were applied.
Unresolved Items
File:
metadata.yamlReason: Mandatory `metadata.yaml` validation found `otel.instrumentation.common.experimental.controller-telemetry.enabled` is missing `declarative_name: java.common.controller_telemetry/development.enabled`; not changed because it is outside the requested `instrumentation/jsf/jsf-common-javax/testing` path.
Module:
jsf-mojarra-1.2:javaagentModule path:
instrumentation/jsf/jsf-mojarra-1.2/javaagentSummary
Applied and committed one safe repository-guideline fix: added the missing declarative config name for the JSF Mojarra 1.2 controller telemetry setting.
Applied Changes
Config
File:
metadata.yaml:10Change: Added `declarative_name: java.common.controller_telemetry/development.enabled` for `otel.instrumentation.common.experimental.controller-telemetry.enabled`.
Reason: `metadata-yaml-format.md` requires every instrumentation config entry to include the correct declarative YAML key; this matches the special mapping for `otel.instrumentation.common.experimental.controller-telemetry.enabled` and sibling JSF module metadata.
Unresolved Items
File:
build.gradle.ktsReason: Bounded muzzle `pass` ranges lack some `assertInverse.set(true)` entries per `gradle-conventions.md`, but adding them was not safe: `:muzzle` failed during configuration with duplicate generated muzzle configurations for existing overlapping `fail`/`pass` ranges. This needs a manual muzzle configuration or convention-plugin adjustment.
Module:
jsf-mojarra-3.0:javaagentModule path:
instrumentation/jsf/jsf-mojarra-3.0/javaagentSummary
Applied safe repository-guideline fixes to
instrumentation/jsf/jsf-mojarra-3.0/javaagent/build.gradle.ktsand committed them in1867c1eb.Applied Changes
Build
File:
build.gradle.kts:10Change: Moved `assertInverse.set(true)` immediately after `versions.set("[3,)")` and changed single-test-task configuration from `withType<Test>().configureEach` to `test`.
Reason: `gradle-conventions.md` requires `assertInverse.set(true)` immediately after `versions.set(...)` in muzzle pass blocks, and says single-test-task modules should use `tasks.test` for shared test JVM/system-property configuration; `latestDepTest` does not justify `withType<Test>().configureEach`.
Module:
jsf-myfaces-1.2:javaagentModule path:
instrumentation/jsf/jsf-myfaces-1.2/javaagentSummary
Applied and committed one safe repository-guideline fix for
jsf-myfaces-1.2javaagent; validation completed with:check,:check -PtestLatestDeps=true,:muzzle, andspotlessApply.Applied Changes
Build
File:
build.gradle.kts:10Change: Moved `assertInverse.set(true)` immediately after `versions.set("[1.2,3)")` in the `muzzle` `pass` block.
Reason: `gradle-conventions.md` requires `assertInverse.set(true)` in javaagent muzzle `pass` blocks to appear immediately after `versions.set(...)` unless `skip(...)` is present.
Module:
jsf-myfaces-3.0:javaagentModule path:
instrumentation/jsf/jsf-myfaces-3.0/javaagentSummary
Applied one safe repository-guideline fix under
instrumentation/jsf/jsf-myfaces-3.0/javaagentand committed it as48705c83.Applied Changes
Build
File:
build.gradle.kts:41Change: Changed test configuration from `withType<Test>().configureEach` to `test` for the module’s `jvmArgs`, `collectMetadata`, and `metadataConfig` settings.
Reason: The Gradle convention says single-test-task modules should use `tasks.test`; implicit `latestDepTest` does not justify `withType<Test>().configureEach`.
Module:
jsp-2.3:javaagentModule path:
instrumentation/jsp-2.3/javaagentSummary
Applied and committed one safe review fix for
jsp-2.3javaagent tests.Applied Changes
Testing
File:
JspSpanAssertions.java:34Change: Made `EXPERIMENTAL_ATTRIBUTES` private and added `hasTotalAttributeCount(0)` when JSP experimental render-span attributes are disabled.
Reason: `testing-experimental-flags.md` says per-module experimental flags should be held in a `private static final` constant, and `testing-general-patterns.md` standardizes zero-attribute assertions on `hasTotalAttributeCount(0)`.
Module:
kafka-clients-0.11:bootstrapModule path:
instrumentation/kafka/kafka-clients/kafka-clients-0.11/bootstrapSummary
Applied and committed safe review fixes for the Kafka bootstrap helper: renamed
setEnabled(...)tosetWrappingEnabled(...)and updated all direct Kafka javaagent callers.Applied Changes
Naming
File:
KafkaClientsConsumerProcessTracing.java:17Change: Renamed `setEnabled(boolean)` to `setWrappingEnabled(boolean)` to match the existing `wrappingEnabled` state and `isWrappingEnabled()` accessor.
Reason: Repository naming guidance expects `set*` methods to name the property they mutate; javaagent/bootstrap internals are not public API, so the API-deprecation guidance allows a direct rename with in-repo caller updates.
Javaagent
File:
KafkaConsumerInstrumentation.java:73Change: Updated calls from `KafkaClientsConsumerProcessTracing.setEnabled(...)` to `setWrappingEnabled(...)`.
Reason: The javaagent API-deprecation guidance says javaagent internals are not public API and direct in-repo callers should be updated in the same commit after an internal rename.
File:
WorkerSinkTaskInstrumentation.java:42Change: Updated calls from `KafkaClientsConsumerProcessTracing.setEnabled(...)` to `setWrappingEnabled(...)`.
Reason: The javaagent API-deprecation guidance says javaagent internals are not public API and direct in-repo callers should be updated in the same commit after an internal rename.
File:
StreamThreadInstrumentation.java:34Change: Updated calls from `KafkaClientsConsumerProcessTracing.setEnabled(...)` to `setWrappingEnabled(...)`.
Reason: The javaagent API-deprecation guidance says javaagent internals are not public API and direct in-repo callers should be updated in the same commit after an internal rename.
Download code review diagnostics