PR dashboard: ignore merge-from-base commits made by non-authors#18485
Merged
laurit merged 1 commit intoMay 2, 2026
Conversation
The is_substantive() filter excluded "Update branch" merge commits from the latest-event determination, but treated all merge commits the same regardless of who made them, and the LLM-rendered context still surfaced them in the "Last N commits" listing and used their timestamp for "Last commit pushed". Refine the rule to only ignore merge commits authored by someone other than the PR author (e.g. an approver clicking "Update branch" on someone else's PR, as on open-telemetry#18090). Author-driven merges of base into the PR remain substantive. Apply the same rule to the rendered commit listing and last_commit_date.
trask
force-pushed
the
dashboard-merge-from-base-context
branch
from
280c116 to
b05ce14
Compare
trask
changed the title
laurit
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refines the rule to ignore merge commits authored by someone other than the PR author (e.g. an approver clicking "Update branch" on someone else's PR, as on #18090).