Code review sweep (run 25243457683)#18504
Merged
Merged
Conversation
Automated code review of instrumentation/servlet/servlet-common/bootstrap.
Automated code review of instrumentation/servlet/servlet-common/javaagent.
Automated code review of instrumentation/servlet/servlet-common/library.
Automated code review of instrumentation/spring/spring-batch-3.0/javaagent.
Automated code review of instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagent.
Automated code review of instrumentation/spring/spring-boot-autoconfigure.
Automated code review of instrumentation/spring/spring-boot-autoconfigure/testing.
trask
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:
servlet-common-javax:libraryservlet-common:bootstrapservlet-common:javaagentservlet-common:libraryspark-2.3:javaagentspring-batch-3.0:javaagentspring-boot-actuator-autoconfigure-2.0:javaagentspring:spring-boot-autoconfigurespring-boot-autoconfigure:testingModule:
servlet-common-javax:libraryModule path:
instrumentation/servlet/servlet-common-javax/librarySummary
No safe repository-guideline fixes were found in
instrumentation/servlet/servlet-common-javax/library; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
servlet-common:bootstrapModule path:
instrumentation/servlet/servlet-common/bootstrapSummary
Applied 1 safe repository-guideline fix under
instrumentation/servlet/servlet-common/bootstrapand committed it.Applied Changes
Style
File:
ServletContextPath.java:30Change: Moved the `contextPath` instance field and private `ServletContextPath(...)` constructor above static methods, keeping construction-related members together.
Reason: Repository style guide class organization prefers static fields, then instance fields, constructors, and methods; static factory methods should sit next to constructors in the construction section.
Module:
servlet-common:javaagentModule path:
instrumentation/servlet/servlet-common/javaagentSummary
Applied safe visibility fixes in
servlet-commonjavaagent helpers and committed them as8b3131ad.Applied Changes
Style
File:
AsyncRequestCompletionListener.java:15Change: Reduced `AsyncRequestCompletionListener` and its constructor from `public` to package-private.
Reason: The repository style guide requires minimal necessary visibility; sibling-module caller search showed this helper is only instantiated from `ServletHelper` in the same package.
File:
AsyncRunnableWrapper.java:11Change: Reduced `AsyncRunnableWrapper` and its `wrap(...)` factory from `public` to package-private.
Reason: The repository style guide requires minimal necessary visibility; sibling-module caller search showed this wrapper is only used by `ServletHelper` in the same package.
Module:
servlet-common:libraryModule path:
instrumentation/servlet/servlet-common/librarySummary
Applied one safe repository-guideline fix in
instrumentation/servlet/servlet-common/libraryand committed it ased81f713.Applied Changes
General
File:
ServletRequestParametersExtractor.java:70Change: Renamed the `parameterAttributeKey` argument from `headerName` to `parameterName`.
Reason: Fixes a copy/paste naming mismatch under the general review rule for correctness and misleading identifiers; this helper handles servlet request parameters, not headers.
Module:
spark-2.3:javaagentModule path:
instrumentation/spark-2.3/javaagentSummary
No safe repository-guideline fixes were found for
instrumentation/spark-2.3/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
spring-batch-3.0:javaagentModule path:
instrumentation/spring/spring-batch-3.0/javaagentSummary
Applied one safe repository-guideline fix in
spring-batch-3.0javaagent and committed it as1fa72804.Applied Changes
General
File:
TracingChunkExecutionListener.java:40Change: Corrected copy/paste comments to reference `beforeChunk`/`afterChunk` and `TracingChunkExecutionListener` instead of job listener names.
Reason: `knowledge/general-rules.md` requires fixing incorrect comments and copy/paste mistakes when deterministic and safe.
Module:
spring-boot-actuator-autoconfigure-2.0:javaagentModule path:
instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagentSummary
Applied one safe repository-guideline fix in
spring-boot-actuator-autoconfigure-2.0javaagent and committed it.Applied Changes
Build
File:
build.gradle.kts:32Change: Changed broad `tasks.withType<Test>().configureEach` configuration to `tasks.test`.
Reason: `gradle-conventions.md` says single-test-task modules should use the simple `tasks.test` form; implicit `latestDepTest` does not justify `withType<Test>().configureEach`.
Module:
spring:spring-boot-autoconfigureModule path:
instrumentation/spring/spring-boot-autoconfigureSummary
Applied 1 safe repository-guideline fix and committed it in
07c388e8.Applied Changes
Config
File:
metadata.yaml:8Change: Added a `configurations` entry for `otel.instrumentation.kafka.autoconfigure-interceptor` with `declarative_name` `java.kafka.autoconfigure_interceptor`, type `boolean`, and default `true`.
Reason: `metadata-yaml-format.md` requires instrumentation module metadata to cover config properties read by source code; `KafkaInstrumentationAutoConfiguration` reads this property via `@ConditionalOnProperty`.
Module:
spring-boot-autoconfigure:testingModule path:
instrumentation/spring/spring-boot-autoconfigure/testingSummary
Applied safe style-guide visibility fixes in
spring-boot-autoconfiguretestingand committed them.Applied Changes
Style
File:
AbstractKafkaInstrumentationAutoConfigurationTest.java:22Change: Changed unused `contextRunner` field visibility from `protected` to `private`.
Reason: Repository style guide requires the minimal necessary visibility; subclasses do not access this `contextRunner` field.
File:
AbstractMicrometerBridgeAutoConfigurationTest.java:26Change: Changed unused `contextRunner` field visibility from `protected` to `private`.
Reason: Repository style guide requires the minimal necessary visibility; subclasses do not access this `contextRunner` field.
File:
AbstractR2DbcInstrumentationAutoConfigurationTest.java:24Change: Changed unused `contextRunner` field visibility from `protected` to `private`.
Reason: Repository style guide requires the minimal necessary visibility; subclasses do not access this `contextRunner` field.
File:
AbstractRestClientInstrumentationAutoConfigurationTest.java:26Change: Changed unused `contextRunner` field visibility from `protected` to `private`.
Reason: Repository style guide requires the minimal necessary visibility; subclasses do not access this `contextRunner` field.
File:
AbstractSpringWebInstrumentationAutoConfigurationTest.java:21Change: Changed unused `contextRunner` field visibility from `protected` to `private`.
Reason: Repository style guide requires the minimal necessary visibility; subclasses do not access this `contextRunner` field.
Download code review diagnostics