Code review sweep (run 25244636897)#18505
Merged
Merged
Conversation
Automated code review of instrumentation/spring/spring-boot-resources/javaagent.
Automated code review of instrumentation/spring/spring-cloud-aws-3.0/javaagent.
Automated code review of instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-2.2/testing.
Automated code review of instrumentation/spring/spring-core-2.0/javaagent.
Automated code review of instrumentation/spring/spring-data/spring-data-3.0/testing.
Automated code review of instrumentation/spring/spring-data/spring-data-common/testing.
Automated code review of instrumentation/spring/spring-integration-4.1/library.
Automated code review of instrumentation/spring/spring-integration-4.1/testing.
trask
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:
spring-boot-resources:javaagentspring-boot-resources:javaagent-unit-testsspring-cloud-aws-3.0:javaagentspring-cloud-gateway-2.0:javaagentspring-cloud-gateway-2.2:testingspring-cloud-gateway-common:javaagentspring-cloud-gateway-common:testingspring-cloud-gateway-webflux-4.3:testingspring-cloud-gateway-webmvc-4.3:javaagentspring-core-2.0:javaagentspring-data-1.8:javaagentspring-data-3.0:kotlin-testingspring-data-3.0:testingspring-data-common:testingspring-integration-4.1:javaagentspring-integration-4.1:libraryspring-integration-4.1:testingModule:
spring-boot-resources:javaagentModule path:
instrumentation/spring/spring-boot-resources/javaagentSummary
Applied one safe repository-guideline fix and committed it in
f60c03ce(Review fixes for spring-boot-resources javaagent).Applied Changes
Style
File:
SystemHelper.java:35Change: Added `@Nullable` to `SystemHelper.getenv()`, `getProperty()`, `openClasspathResource()`, and `openJarRootResource()` return types.
Reason: Repository nullability guidance requires annotating return types that can actually return `null`; these methods delegate to JDK APIs (`System.getenv()`, `System.getProperty()`, and `ClassLoader.getResourceAsStream()`) that return `null` when values or resources are absent.
Module:
spring-boot-resources:javaagent-unit-testsModule path:
instrumentation/spring/spring-boot-resources/javaagent-unit-testsSummary
No safe repository-guideline fixes were applied under
instrumentation/spring/spring-boot-resources/javaagent-unit-tests; the reviewedmetadata.yamlhas no config entries requiring declarative-name validation fixes.Applied Changes
No safe automated changes were applied.
Module:
spring-cloud-aws-3.0:javaagentModule path:
instrumentation/spring/spring-cloud-aws-3.0/javaagentSummary
Applied one safe repository-guideline fix in
spring-cloud-aws-3.0javaagent tests and committed it.Applied Changes
Testing
File:
AwsSqsTest.java:72Change: Collapsed the `@Test` method `sqsListener()` from three checked exception types to a single `throws Exception` clause and removed now-unused exception imports.
Reason: `testing-general-patterns.md` requires `@Test` methods to keep `throws` clauses to a single exception type; the timeout-based `CompletableFuture.get(...)` path does not have a narrower clean single checked type.
Module:
spring-cloud-gateway-2.0:javaagentModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-2.0/javaagentSummary
Reviewed
spring-cloud-gateway-2.0/javaagent; no safe repository-guideline fixes were applied.Applied Changes
No safe automated changes were applied.
Module:
spring-cloud-gateway-2.2:testingModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-2.2/testingSummary
Applied 1 safe repository-guideline fix under
spring-cloud-gateway-2.2/testing; 1 larger experimental-test-task issue remains unresolved because the review workflow says not to auto-fix missingtestExperimentaltasks.Applied Changes
Build
File:
build.gradle.kts:20Change: Changed `tasks.withType<Test>().configureEach` to `tasks.test`.
Reason: `gradle-conventions.md` says single-test-task modules should prefer `tasks.test`; implicit `latestDepTest` does not count as an additional custom `Test` task.
Unresolved Items
File:
build.gradle.ktsReason: The default `test` task still enables experimental JVM args without a dedicated `testExperimental` task; `testing-experimental-flags.md` requires a dedicated task, but the review instructions classify missing `testExperimental` as report-only rather than auto-fix.
Module:
spring-cloud-gateway-common:javaagentModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/javaagentSummary
No safe repository-guideline fixes were found in the tracked files under
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/javaagent.Applied Changes
No safe automated changes were applied.
Module:
spring-cloud-gateway-common:testingModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common/testingSummary
No safe fixes were applied. The only deterministic candidate, replacing
hasAttributesSatisfying(...)withhasAttributesSatisfyingExactly(...), was reverted because dependent:instrumentation:spring:spring-cloud-gateway:spring-cloud-gateway-2.0:javaagent:checktests failed: the assertions intentionally cover only Spring Cloud Gateway-enriched attributes while server spans also include HTTP/server attributes.Applied Changes
No safe automated changes were applied.
Unresolved Items
File:
AbstractRouteMappingTest.javaReason: `hasAttributesSatisfying(...)` is less precise than the testing guideline preference for `hasAttributesSatisfyingExactly(...)`, but converting it is not safe without also defining all expected server-span attributes across gateway variants; the attempted change failed dependent tests and was reverted.
Module:
spring-cloud-gateway-webflux-4.3:testingModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-webflux-4.3/testingSummary
No safe repository-guideline fixes were applied in the requested
testingdirectory.Applied Changes
No safe automated changes were applied.
Unresolved Items
File:
build.gradle.ktsReason: Experimental JVM flags are applied directly to the default `test` task without a dedicated `testExperimental` task; the review workflow classifies missing `testExperimental` wiring as not auto-fixable and requires reporting instead.
Module:
spring-cloud-gateway-webmvc-4.3:javaagentModule path:
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-webmvc-4.3/javaagentSummary
No safe repository-guideline fixes were applied. Reviewed the requested
javaagentfiles and mandatorymetadata.yaml; no deterministic issues were found in scope.Applied Changes
No safe automated changes were applied.
Module:
spring-core-2.0:javaagentModule path:
instrumentation/spring/spring-core-2.0/javaagentSummary
Applied one safe repository-guideline fix in
spring-core-2.0javaagent and committed it.Applied Changes
Style
File:
SimpleAsyncTaskExecutorInstrumentationTest.java:42Change: Renamed the unused `NoSuchMethodException` catch variable from `e` to `ignored`.
Reason: `knowledge/general-rules.md` catch-variable guidance says intentionally unused catch parameters should use `ignored`.
Module:
spring-data-1.8:javaagentModule path:
instrumentation/spring/spring-data/spring-data-1.8/javaagentSummary
No safe repository-guideline fixes were found under
instrumentation/spring/spring-data/spring-data-1.8/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
spring-data-3.0:kotlin-testingModule path:
instrumentation/spring/spring-data/spring-data-3.0/kotlin-testingSummary
No safe repository-guideline fixes were needed for
instrumentation/spring/spring-data/spring-data-3.0/kotlin-testing; the scoped files and relatedmetadata.yamlwere already consistent with the loaded review rules.Applied Changes
No safe automated changes were applied.
Module:
spring-data-3.0:testingModule path:
instrumentation/spring/spring-data/spring-data-3.0/testingSummary
Applied one safe repository-guideline fix in
spring-data-3.0testing and committed it.Applied Changes
Testing
File:
ReactiveSpringDataTest.java:38Change: Moved `@SuppressWarnings("deprecation")` from `testFindAll()` to `ReactiveSpringDataTest` class scope while preserving the explanatory semconv comment.
Reason: `testing-semconv-stability.md` requires class-level deprecation suppression when tests use deprecated semconv constants.
Module:
spring-data-common:testingModule path:
instrumentation/spring/spring-data/spring-data-common/testingSummary
Applied 1 safe repository-guideline fix under
instrumentation/spring/spring-data/spring-data-common/testingand committed it ascc373169.Applied Changes
Style
File:
AbstractSpringJpaTest.java:38Change: Moved repeated `@SuppressWarnings("deprecation")` annotations for `DB_CONNECTION_STRING` from individual methods to class scope while preserving the explanatory TODO comment.
Reason: Repository `@SuppressWarnings` guidance says to place a suppression on the class when two or more members need the same suppression and to preserve accurate explanatory comments.
Module:
spring-integration-4.1:javaagentModule path:
instrumentation/spring/spring-integration-4.1/javaagentSummary
No safe repository-guideline fixes were found in the reviewed
spring-integration-4.1javaagentfiles.Applied Changes
No safe automated changes were applied.
Module:
spring-integration-4.1:libraryModule path:
instrumentation/spring/spring-integration-4.1/librarySummary
Applied and committed two safe repository-guideline fixes for
spring-integration-4.1library.Applied Changes
Build
File:
build.gradle.kts:27Change: Changed broad `withType<Test>().configureEach` test configuration to `test` for the module's single explicit test task.
Reason: `gradle-conventions.md` says single-test-task modules should use `tasks.test`; implicit `latestDepTest` does not justify broad `withType<Test>()` configuration.
Style
File:
SpringIntegrationTelemetryBuilder.java:104Change: Moved private `consumerSpanName` and `producerSpanName` helpers below the public `build()` method that uses them.
Reason: The style guide's method ordering rule places calling methods above the private helper methods they call.
Module:
spring-integration-4.1:testingModule path:
instrumentation/spring/spring-integration-4.1/testingSummary
Applied and committed 2 safe repository-guideline fixes in
spring-integration-4.1testing sources.Applied Changes
Testing
File:
AbstractComplexPropagationTest.java:39Change: Replaced nullable `@AfterEach` cleanup of `ConfigurableApplicationContext` with `AutoCleanupExtension` and `cleanup.deferCleanup(applicationContext)`.
Reason: `testing-general-patterns.md` recommends `AutoCleanupExtension.deferCleanup(...)` for JUnit resources that stay live for the test and only need cleanup at test end.
File:
AbstractSpringIntegrationTracingTest.java:41Change: Replaced nullable `@AfterEach` cleanup of `ConfigurableApplicationContext` with `AutoCleanupExtension` and `cleanup.deferCleanup(applicationContext)`.
Reason: `testing-general-patterns.md` recommends `AutoCleanupExtension.deferCleanup(...)` for JUnit resources that stay live for the test and only need cleanup at test end.
Download code review diagnostics