First pass at flaky VertxReactivePropagationTest.highConcurrency#18511
Closed
trask wants to merge 4 commits into
Closed
First pass at flaky VertxReactivePropagationTest.highConcurrency#18511trask wants to merge 4 commits into
trask wants to merge 4 commits into
Conversation
trask
changed the title
# Conflicts: # instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version35Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java # instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version41Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java # instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version5Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java
This was referenced May 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Vert.x RxJava 3.5 VertxReactivePropagationTest.highConcurrency test variants to make failures more deterministic and easier to debug by adding bounded waits and ensuring all submitted request tasks complete before trace assertions run.
Changes:
- Add a timeout/assertion around the start latch to avoid silent hangs.
- Track
Futures from submitted tasks and wait for completion before asserting traces. - Update the test method signature to allow propagation of checked exceptions from task completion waits.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version35Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java | Add latch timeout assertion and wait for all task futures before validating traces. |
| instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version41Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java | Same concurrency test hardening (timeouts + Future waiting) for the 4.1 test variant. |
| instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version5Test/java/io/opentelemetry/javaagent/instrumentation/vertx/rx/v3_5/server/VertxReactivePropagationTest.java | Same concurrency test hardening (timeouts + Future waiting) for the 5.x test variant. |
laurit
reviewed
May 12, 2026
| @@ -160,29 +163,36 @@ void highConcurrency() { | |||
| TextMapSetter<HttpRequestBuilder> setter = | |||
| (carrier, name, value) -> carrier.header(name, value); | |||
|
|
|||
| List<Future<?>> futures = new ArrayList<>(); | |||
Contributor
There was a problem hiding this comment.
I guess this won't do anything to fix the flaky test. If you believe that waiting for all the submitted tasks helps I'd suggest to also change the highConcurrency method in AbstractHttpClientTest that these methods copy from.
I get why copilot is forcing recomputing the deadline, but it looks a bit too much effort. Maybe we could avoid it with the following
CompletableFuture<?>[] tasks = new CompletableFuture[count];
for (int i = 0; i < count; i++) {
tasks[i] = CompletableFuture.runAsync(job, pool);
}
latch.countDown();
CompletableFuture.allOf(tasks).get(30, SECONDS);
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #18508
I removed the manual context propagation because worried that might be hiding something.
But the other changes look good and could help narrow down future flaky diagnosis of this test.