Code review sweep (run 25258026678)

[otelbot]

Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:

• vertx-http-client-common-3.0:javaagent
• vertx-kafka-client-3.6:javaagent
• vertx-kafka-client-3.6:testing
• vertx-kafka-client-3.6:vertx-kafka-client-3.6-testing
• vertx-kafka-client-3.6:vertx-kafka-client-4-testing
• vertx-kafka-client-3.6:vertx-kafka-client-5-testing
• vertx-redis-client-4.0:javaagent
• vertx-rx-java-3.5:javaagent
• vertx-sql-client-4.0:javaagent
• vertx-sql-client-5.0:javaagent
• vertx-sql-client-common-4.0:javaagent
• vertx-web-3.0:javaagent

---

Module: vertx-http-client-common-3.0:javaagent

Module path: instrumentation/vertx/vertx-http-client/vertx-http-client-common-3.0/javaagent

Summary

No safe repository-guideline fixes were applied under instrumentation/vertx/vertx-http-client/vertx-http-client-common-3.0/javaagent; the reviewed files already matched the applicable style, Javaagent, singleton, nullability, and metadata review guidance for this scope.

Applied Changes

No safe automated changes were applied.

Module: vertx-kafka-client-3.6:javaagent

Module path: instrumentation/vertx/vertx-kafka-client-3.6/javaagent

Summary

No safe repository-guideline fixes were found under instrumentation/vertx/vertx-kafka-client-3.6/javaagent; no files were changed.

Applied Changes

No safe automated changes were applied.

Module: vertx-kafka-client-3.6:testing

Module path: instrumentation/vertx/vertx-kafka-client-3.6/testing

Summary

No safe repository-guideline fixes were found under instrumentation/vertx/vertx-kafka-client-3.6/testing; no files were changed.

Applied Changes

No safe automated changes were applied.

Module: vertx-kafka-client-3.6:vertx-kafka-client-3.6-testing

Module path: instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-3.6-testing

Summary

No safe repository-guideline fixes were applied after reviewing all files under instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-3.6-testing.

Applied Changes

No safe automated changes were applied.

Module: vertx-kafka-client-3.6:vertx-kafka-client-4-testing

Module path: instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-4-testing

Summary

No safe repository-guideline fixes were needed for the reviewed vertx-kafka-client-4-testing files.

Applied Changes

No safe automated changes were applied.

Module: vertx-kafka-client-3.6:vertx-kafka-client-5-testing

Module path: instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-5-testing

Summary

Applied one safe review fix and committed it as 1b207c50 (Review fixes for vertx-kafka-client-5-testing).

Applied Changes

Testing

File: build.gradle.kts:49
Change: Moved `otel.instrumentation.kafka.experimental-span-attributes=true` from the default `test` task into a dedicated `testExperimental` task, wired it into `check`, and added matching `metadataConfig` values for the non-default test modes.
Reason: `testing-experimental-flags.md` requires experimental attribute flags to run in a dedicated `testExperimental` task, and `gradle-conventions.md` requires custom `Test` tasks to set `testClassesDirs`, `classpath`, and be wired into `check`.

Module: vertx-redis-client-4.0:javaagent

Module path: instrumentation/vertx/vertx-redis-client-4.0/javaagent

Summary

Applied and committed one safe metadata fix for vertx-redis-client-4.0: added the missing declarative_name for otel.instrumentation.common.peer-service-mapping.

Applied Changes

Config

File: metadata.yaml:16
Change: Added `declarative_name: java.common.peer_service_mapping` to the `otel.instrumentation.common.peer-service-mapping` configuration entry.
Reason: `metadata-yaml-format.md` requires each configuration entry to include a matching `declarative_name`; sibling metadata files use `java.common.peer_service_mapping` for this common peer-service property.

Module: vertx-rx-java-3.5:javaagent

Module path: instrumentation/vertx/vertx-rx-java-3.5/javaagent

Summary

Applied and committed safe style fixes for vertx-rx-java-3.5 javaagent tests.

Applied Changes

Style

File: VertxReactivePropagationTest.java:169
Change: Renamed the unused `InterruptedException` catch variable from `e` to `ignored`.
Reason: `knowledge/general-rules.md` catch-variable guidance says intentionally unused catch parameters should be named `ignored`.

File: VertxReactivePropagationTest.java:169
Change: Renamed the unused `InterruptedException` catch variable from `e` to `ignored`.
Reason: `knowledge/general-rules.md` catch-variable guidance says intentionally unused catch parameters should be named `ignored`.

File: VertxReactivePropagationTest.java:169
Change: Renamed the unused `InterruptedException` catch variable from `e` to `ignored`.
Reason: `knowledge/general-rules.md` catch-variable guidance says intentionally unused catch parameters should be named `ignored`.

Module: vertx-sql-client-4.0:javaagent

Module path: instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent

Summary

Applied one safe repository-guideline fix and committed it in 27079041 (Review fixes for vertx-sql-client-4.0 javaagent).

Applied Changes

Style

File: VertxSqlClientSingletons.java:29
Change: Moved the `instrumenter()` accessor below all static fields so the static field block remains contiguous.
Reason: The repository style guide class-organization rule places static fields before methods.

Module: vertx-sql-client-5.0:javaagent

Module path: instrumentation/vertx/vertx-sql-client/vertx-sql-client-5.0/javaagent

Summary

Applied and committed one safe repository-guideline fix for vertx-sql-client-5.0 javaagent advice cleanup.

Applied Changes

Javaagent

File: PoolInstrumentation.java:80
Change: Updated `PoolAdvice.onExit()` to run with `onThrowable = Throwable.class`, mark `@Advice.Return` `Pool` as `@Nullable`, guard pool-specific VirtualField writes, and always clear the connection-options thread-local after the outer call-depth exits.
Reason: Javaagent advice cleanup must run on exceptional exits when enter advice mutates state; `@Nullable` documents the concrete ByteBuddy null return path when `Pool.pool(...)` throws.

Module: vertx-sql-client-common-4.0:javaagent

Module path: instrumentation/vertx/vertx-sql-client/vertx-sql-client-common-4.0/javaagent

Summary

Applied and committed one safe repository-guideline fix in vertx-sql-client-common-4.0 javaagent.

Applied Changes

Style

File: VertxSqlClientUtil.java:102
Change: Changed `RequestData` fields from package-visible `final` fields to `private final` fields.
Reason: Repository style guide requires minimal necessary visibility; `RequestData` is a private nested helper and its fields are only accessed by the enclosing `VertxSqlClientUtil`.

Module: vertx-web-3.0:javaagent

Module path: instrumentation/vertx/vertx-web-3.0/javaagent

Summary

Applied 2 safe review fixes for vertx-web-3.0 javaagent and committed them in c8590df8.

Applied Changes

General

File: build.gradle.kts:17
Change: Fixed the Gradle dependency comment from `both version` to `both versions`.
Reason: The general review checklist includes correcting inaccurate or malformed comments; this keeps the comment factual and grammatically clear.

Style

File: RoutingContextHandlerWrapper.java:41
Change: Renamed the unused `Scope` resource variable from `ignore` to `ignored`.
Reason: Repository style favors clear names for intentionally unused values, and `ignored` matches the established in-repo convention for unused `Scope` resources.

---

Download code review diagnostics