Code review sweep (run 25260462600)#18518
Merged
Merged
Conversation
Automated code review of instrumentation/clickhouse/clickhouse-client-common-0.5/javaagent.
Automated code review of instrumentation/play/play-ws/play-ws-common-1.0/testing.
Automated code review of instrumentation/vibur-dbcp-11.0/javaagent.
Automated code review of instrumentation/vibur-dbcp-11.0/testing.
Automated code review of instrumentation/wicket-8.0/javaagent.
Automated code review of instrumentation/wicket-8.0/wicket10-testing.
Automated code review of instrumentation/xxl-job/xxl-job-1.9.2/javaagent.
Automated code review of instrumentation/xxl-job/xxl-job-common/testing.
Automated code review of instrumentation/zio/zio-2.0/javaagent.
trask
force-pushed
the
otelbot/code-review-sweep-25260462600
branch
from
ef0b8b1 to
988ce88
Compare
trask
approved these changes
May 2, 2026
…-sweep-25260462600 # Conflicts: # instrumentation/wicket-8.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/wicket/v8_0/WicketServerSpanNaming.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review sweep walked the following modules in order
and stopped after accumulating at least 10 modified files:
clickhouse-client-common-0.5:javaagentplay-ws-common-1.0:javaagentplay-ws-common-1.0:testingvertx-web-3.0:testingvibur-dbcp-11.0:javaagentvibur-dbcp-11.0:libraryvibur-dbcp-11.0:testingwicket-8.0:common-testingwicket-8.0:javaagentwicket-8.0:wicket10-testingwicket-8.0:wicket8-testingxxl-job-1.9.2:javaagentxxl-job-2.1.2:javaagentxxl-job-2.3.0:javaagentxxl-job-common:javaagentxxl-job-common:testingzio-2.0:javaagentModule:
clickhouse-client-common-0.5:javaagentModule path:
instrumentation/clickhouse/clickhouse-client-common-0.5/javaagentSummary
Applied one safe repository-guideline fix under
instrumentation/clickhouse/clickhouse-client-common-0.5/javaagentand committed it.Applied Changes
Style
File:
ClickHouseAttributesGetter.java:18Change: Removed the `final` modifier from `ClickHouseAttributesGetter`.
Reason: The style guide says classes under `javaagent/src/main` are not public API and should not be declared `final`.
Module:
play-ws-common-1.0:javaagentModule path:
instrumentation/play/play-ws/play-ws-common-1.0/javaagentSummary
No safe repository-guideline fixes were applied under
instrumentation/play/play-ws/play-ws-common-1.0/javaagent; the reviewed files already conform to the applicable style, javaagent advice/module, singleton, Gradle, and metadata rules in scope.Applied Changes
No safe automated changes were applied.
Module:
play-ws-common-1.0:testingModule path:
instrumentation/play/play-ws/play-ws-common-1.0/testingSummary
Applied one safe repository-guideline fix and committed it in
f5da0005(Review fixes for play-ws-common-1.0 testing).Applied Changes
Style
File:
PlayWsClientBaseTest.java:47Change: Changed `asyncHttpClient`, `asyncHttpClientWithReadTimeout`, and `materializer` from `protected static` to package-private `static`.
Reason: The style guide requires minimal necessary visibility; these shared test-helper fields are only used by classes in the same package.
Module:
vertx-web-3.0:testingModule path:
instrumentation/vertx/vertx-web-3.0/testingSummary
No safe repository-guideline fixes were found in
instrumentation/vertx/vertx-web-3.0/testing; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
vibur-dbcp-11.0:javaagentModule path:
instrumentation/vibur-dbcp-11.0/javaagentSummary
Applied one safe javaagent style fix and committed it in
7fb85139.Applied Changes
Javaagent
File:
ViburDbcpInstrumentationModule.java:27Change: Moved the single-class `hasClassesNamed("org.vibur.dbcp.ViburConfig")` landmark into the compact `classLoaderMatcher()` form.
Reason: `javaagent-module-patterns.md` requires compact formatting for a single-class `classLoaderMatcher()` landmark with the version comment above the return expression.
Module:
vibur-dbcp-11.0:libraryModule path:
instrumentation/vibur-dbcp-11.0/librarySummary
No safe repository-guideline fixes were applied under
instrumentation/vibur-dbcp-11.0/library; reviewable source, test, Gradle, and requiredmetadata.yamlchecks did not reveal deterministic issues.Applied Changes
No safe automated changes were applied.
Module:
vibur-dbcp-11.0:testingModule path:
instrumentation/vibur-dbcp-11.0/testingSummary
Applied one safe repository-guideline fix in
instrumentation/vibur-dbcp-11.0/testingand committed it.Applied Changes
Testing
File:
AbstractViburInstrumentationTest.java:38Change: Replaced checked `Thread.sleep`/`MILLISECONDS.sleep` calls with `await().pollDelay(EXPORTER_INTERVAL).until(() -> true)` and narrowed `shouldReportMetrics()` to `throws SQLException`.
Reason: The testing review guideline requires `@Test` methods to use a single checked exception type as specifically as possible; using `Duration`-based Awaitility delays removes the `InterruptedException` source while satisfying Error Prone’s `InterruptedExceptionSwallowed` and `PreferJavaTimeOverload` rules.
Module:
wicket-8.0:common-testingModule path:
instrumentation/wicket-8.0/common-testingSummary
No safe repository-guideline fixes were found under
instrumentation/wicket-8.0/common-testing; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
wicket-8.0:javaagentModule path:
instrumentation/wicket-8.0/javaagentSummary
Applied safe javaagent naming fixes for the Wicket 8.0 module and committed them in
aa3e7e75.Applied Changes
Naming
File:
RequestHandlerExecutorInstrumentation.java:45Change: Updated the route getter call from `WicketServerSpanNaming.getServerSpanName()` to `WicketServerSpanNaming.serverSpanName()`.
Reason: Javaagent singleton-style accessors should use lower-camel names matching the backing collaborator rather than JavaBean `get*` prefixes.
File:
WicketServerSpanNaming.java:25Change: Renamed `getServerSpanName()` to `serverSpanName()`.
Reason: Repository javaagent singleton accessor guidance requires zero-argument collaborator accessors to use the same lower-camel name as the backing field.
Module:
wicket-8.0:wicket10-testingModule path:
instrumentation/wicket-8.0/wicket10-testingSummary
Applied one safe repository-guideline fix in
wicket10-testingand committed it.Applied Changes
Build
File:
build.gradle.kts:8Change: Removed the duplicate `testImplementation("org.jsoup:jsoup:1.13.1")` dependency.
Reason: Repository Gradle conventions flag unused or redundant `testImplementation` dependencies; `Jsoup` is used and declared by `:instrumentation:wicket-8.0:common-testing`, while `wicket10-testing` does not reference it directly.
Module:
wicket-8.0:wicket8-testingModule path:
instrumentation/wicket-8.0/wicket8-testingSummary
No safe repository-guideline fixes were applied under
instrumentation/wicket-8.0/wicket8-testing; reviewedbuild.gradle.kts,WicketTest.java, and the parentmetadata.yamlconfig surface with no in-scope violations found.Applied Changes
No safe automated changes were applied.
Module:
xxl-job-1.9.2:javaagentModule path:
instrumentation/xxl-job/xxl-job-1.9.2/javaagentSummary
Applied one safe repository-guideline fix in
xxl-job-1.9.2javaagent and committed it asa3c03142.Applied Changes
Style
File:
XxlJobSingletons.java:34Change: Normalized `@SuppressWarnings({"Unused", "ReturnValueIgnored"})` to use the standard lowercase `"unused"` suppression name.
Reason: Repository review guidance allows deterministic `@SuppressWarnings` normalization, and the javaagent advice/style guidance consistently uses `@SuppressWarnings("unused")` for unused ByteBuddy/muzzle-only members.
Module:
xxl-job-2.1.2:javaagentModule path:
instrumentation/xxl-job/xxl-job-2.1.2/javaagentSummary
No safe repository-guideline fixes were found under
instrumentation/xxl-job/xxl-job-2.1.2/javaagent; no files were changed.Applied Changes
No safe automated changes were applied.
Module:
xxl-job-2.3.0:javaagentModule path:
instrumentation/xxl-job/xxl-job-2.3.0/javaagentSummary
No safe repository-guideline fixes were applied under
instrumentation/xxl-job/xxl-job-2.3.0/javaagent; reviewed source, tests, Gradle wiring, siblingtestInstrumentationreferences, and requiredmetadata.yamlconfig coverage.Applied Changes
No safe automated changes were applied.
Module:
xxl-job-common:javaagentModule path:
instrumentation/xxl-job/xxl-job-common/javaagentSummary
No safe repository-guideline fixes were applied; scoped
xxl-job-common/javaagentfiles and relatedxxl-jobmetadata.yamlentries already matched the loaded review rules.Applied Changes
No safe automated changes were applied.
Module:
xxl-job-common:testingModule path:
instrumentation/xxl-job/xxl-job-common/testingSummary
Applied one safe repository-guideline fix in
xxl-job-common/testing.Applied Changes
Style
File:
ReflectiveMethodsFactory.java:24Change: Renamed unused `catch (Throwable t)` parameters to `catch (Throwable ignored)` in reflective helper methods.
Reason: `knowledge/general-rules.md` catch-variable naming guidance prefers `ignored` for intentionally unused catch parameters.
Module:
zio-2.0:javaagentModule path:
instrumentation/zio/zio-2.0/javaagentSummary
Applied one safe repository-guideline fix in
zio-2.0javaagent and committed it as5b7dcfac.Applied Changes
Style
File:
TracingSupervisor.java:18Change: Replaced non-explanatory `@SuppressWarnings` comments (`// fine`) with factual explanations for the unchecked Scala `Supervisor` generics and raw upstream `ZIO` return type.
Reason: Repository `@SuppressWarnings` guidance says explanatory suppression comments should be accurate and preserved; `// fine` did not explain why the suppressions are required.
Download code review diagnostics