Normalize internal OSGi and Kotlin extension package names#18713
Merged
trask merged 1 commit intoMay 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR normalizes Javaagent instrumentation package names for the internal Eclipse OSGi and OpenTelemetry Kotlin extension instrumentations so that their declared package aligns with the module/artifact naming and on-disk source layout (part of the broader package/module alignment effort in #18428).
Changes:
- Renamed the Kotlin extension instrumentation package from
...instrumentation.extensionkotlin.v1_0to...instrumentation.opentelemetry.extension.kotlin.v1_0. - Renamed the internal Eclipse OSGi instrumentation package from
...instrumentation.internal.osgito...instrumentation.internal.eclipse.osgi.v3_6.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| instrumentation/opentelemetry-extension-kotlin-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opentelemetry/extension/kotlin/v1_0/ContextExtensionInstrumentationModule.java | Updates the module class package to the normalized Kotlin extension namespace. |
| instrumentation/opentelemetry-extension-kotlin-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opentelemetry/extension/kotlin/v1_0/ContextExtensionInstrumentation.java | Updates the type instrumentation class package to match the normalized namespace. |
| instrumentation/internal/internal-eclipse-osgi-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/eclipse/osgi/v3_6/EclipseOsgiInstrumentationModule.java | Updates the module class package to the normalized internal Eclipse OSGi namespace. |
| instrumentation/internal/internal-eclipse-osgi-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/eclipse/osgi/v3_6/EclipseOsgiInstrumentation.java | Updates the type instrumentation class package to match the normalized namespace. |
jaydeluca
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of