Skip to content

Normalize Spark javaagent package name#18714

Merged
laurit merged 1 commit into
open-telemetry:mainfrom
trask:upstream-package-name-spark-v2_3
May 12, 2026
Merged

Normalize Spark javaagent package name#18714
laurit merged 1 commit into
open-telemetry:mainfrom
trask:upstream-package-name-spark-v2_3

Conversation

@trask

@trask trask commented May 12, 2026

Copy link
Copy Markdown
Member

@trask trask marked this pull request as ready for review May 12, 2026 18:07
@trask trask requested a review from a team as a code owner May 12, 2026 18:07
Copilot AI review requested due to automatic review settings May 12, 2026 18:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Normalizes the Spark 2.3 javaagent instrumentation package name so it aligns with the module/versioned directory structure (spark/v2_3) as part of the broader package/module name alignment work in #18428.

Changes:

  • Updated package declarations from io.opentelemetry.javaagent.instrumentation.sparkjava to io.opentelemetry.javaagent.instrumentation.spark.v2_3 in the Spark 2.3 javaagent instrumentation classes.
  • Updated package declarations in Spark 2.3 javaagent tests to match the new package.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
instrumentation/spark-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/TestSparkJavaApplication.java Aligns test helper class package with versioned Spark 2.3 instrumentation package.
instrumentation/spark-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/SparkJavaBasedTest.java Aligns test class package with versioned Spark 2.3 instrumentation package.
instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/SparkRouteUpdater.java Aligns production helper class package with versioned Spark 2.3 instrumentation package.
instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/SparkInstrumentationModule.java Aligns instrumentation module SPI class package with versioned Spark 2.3 instrumentation package.
instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/RoutesInstrumentation.java Aligns ByteBuddy instrumentation class package with versioned Spark 2.3 instrumentation package.

@laurit laurit merged commit a138f86 into open-telemetry:main May 12, 2026
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants