Normalize Spark javaagent package name#18714
Merged
laurit merged 1 commit intoMay 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes the Spark 2.3 javaagent instrumentation package name so it aligns with the module/versioned directory structure (spark/v2_3) as part of the broader package/module name alignment work in #18428.
Changes:
- Updated
packagedeclarations fromio.opentelemetry.javaagent.instrumentation.sparkjavatoio.opentelemetry.javaagent.instrumentation.spark.v2_3in the Spark 2.3 javaagent instrumentation classes. - Updated
packagedeclarations in Spark 2.3 javaagent tests to match the new package.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/spark-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/TestSparkJavaApplication.java | Aligns test helper class package with versioned Spark 2.3 instrumentation package. |
| instrumentation/spark-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/SparkJavaBasedTest.java | Aligns test class package with versioned Spark 2.3 instrumentation package. |
| instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/SparkRouteUpdater.java | Aligns production helper class package with versioned Spark 2.3 instrumentation package. |
| instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/SparkInstrumentationModule.java | Aligns instrumentation module SPI class package with versioned Spark 2.3 instrumentation package. |
| instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spark/v2_3/RoutesInstrumentation.java | Aligns ByteBuddy instrumentation class package with versioned Spark 2.3 instrumentation package. |
laurit
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of