Normalize external annotations javaagent package name#18715
Merged
laurit merged 1 commit intoMay 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR normalizes the external-annotations javaagent instrumentation package name by renaming the legacy io.opentelemetry.javaagent.instrumentation.extannotations package to io.opentelemetry.javaagent.instrumentation.external.annotations, and updates all test/config references accordingly (aligned with the broader package/module alignment effort in #18428).
Changes:
- Renamed javaagent (main + test) packages from
...extannotationsto...external.annotations. - Updated declarative config YAML test resources to reference the new fully-qualified test class names.
- Updated Gradle test JVM args that reference the test classes in config properties.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/external-annotations/javaagent/src/test/resources/declarative-config-include.yaml | Updates include list to the new test class package name. |
| instrumentation/external-annotations/javaagent/src/test/resources/declarative-config-exclude-methods.yaml | Updates exclude-methods class reference to the new test class package name. |
| instrumentation/external-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/TraceProvidersTest.java | Renames test package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/TracedMethodsExclusionTest.java | Renames test package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/TraceAnnotationsTest.java | Renames test package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/SayTracedHello.java | Renames test package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/OuterClass.java | Renames test package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/ConfiguredTraceAnnotationsTest.java | Renames test package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/external/annotations/ExternalAnnotationSingletons.java | Renames main package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/external/annotations/ExternalAnnotationInstrumentationModule.java | Renames main package declaration to the normalized package. |
| instrumentation/external-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/external/annotations/ExternalAnnotationInstrumentation.java | Renames main package declaration and updates static import to the new package. |
| instrumentation/external-annotations/javaagent/build.gradle.kts | Updates test JVM args using fully-qualified test class names to the new package. |
| instrumentation/external-annotations/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/external/annotations/IncludeTest.java | Renames unit test package and updates static import to the new package. |
laurit
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of