Skip to content

Normalize Hibernate procedure-call javaagent package name#18716

Merged
laurit merged 1 commit into
open-telemetry:mainfrom
trask:upstream-package-name-hibernate-procedure-call
May 12, 2026
Merged

Normalize Hibernate procedure-call javaagent package name#18716
laurit merged 1 commit into
open-telemetry:mainfrom
trask:upstream-package-name-hibernate-procedure-call

Conversation

@trask

@trask trask commented May 12, 2026

Copy link
Copy Markdown
Member

@trask trask marked this pull request as ready for review May 12, 2026 18:07
Copilot AI review requested due to automatic review settings May 12, 2026 18:07
@trask trask requested a review from a team as a code owner May 12, 2026 18:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Normalizes the package name for the Hibernate 4.3 procedure-call javaagent instrumentation so it aligns with the module/artifact naming conventions and avoids using the generic hibernate.v4_3 package for this specialized instrumentation.

Changes:

  • Renamed javaagent main-source packages from ...hibernate.v4_3 to ...hibernate.procedure.call.v4_3.
  • Updated static imports and references to Hibernate43Singletons in the affected instrumentations.
  • Updated the test entity package and the Hibernate test configuration mapping to the new fully-qualified class name.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/test/resources/hibernate.cfg.xml Updates Hibernate test mapping to reference the entity in the new package.
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/procedure/call/v4_3/Value.java Moves the test entity to the normalized package.
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/procedure/call/v4_3/ProcedureCallTest.java Updates test package to match the new package structure.
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hibernate/procedure/call/v4_3/SessionInstrumentation.java Updates package and singleton static imports to the new namespace.
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hibernate/procedure/call/v4_3/ProcedureCallInstrumentation.java Updates package and singleton static imports to the new namespace.
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hibernate/procedure/call/v4_3/HibernateInstrumentationModule.java Updates module class package to the new namespace.
instrumentation/hibernate/hibernate-procedure-call-4.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hibernate/procedure/call/v4_3/Hibernate43Singletons.java Updates singleton holder package to the new namespace.

@laurit laurit merged commit dc2a655 into open-telemetry:main May 12, 2026
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants