Skip to content

Normalize Elasticsearch REST common javaagent package#18720

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-elasticsearch-rest-common
May 13, 2026
Merged

Normalize Elasticsearch REST common javaagent package#18720
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-elasticsearch-rest-common

Conversation

@trask

@trask trask commented May 13, 2026

Copy link
Copy Markdown
Member

@trask trask force-pushed the package-name-cleanup-elasticsearch-rest-common branch from aad58d4 to 7bca404 Compare May 13, 2026 03:19
@trask trask force-pushed the package-name-cleanup-elasticsearch-rest-common branch from 7bca404 to c458e00 Compare May 13, 2026 03:30
@trask trask marked this pull request as ready for review May 13, 2026 03:41
@trask trask requested a review from a team as a code owner May 13, 2026 03:41
Copilot AI review requested due to automatic review settings May 13, 2026 03:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Normalizes the Javaagent package name for the shared Elasticsearch REST “common” instrumenter factory to align package/module naming (per the package/module alignment effort referenced in #18428).

Changes:

  • Moved ElasticsearchRestJavaagentInstrumenterFactory into the versioned ...elasticsearch.rest.common.v5_0 package.
  • Updated Elasticsearch REST 5.0/6.4/7.0 javaagent singletons to import the factory from the new package.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
instrumentation/elasticsearch/elasticsearch-rest-common-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/common/v5_0/ElasticsearchRestJavaagentInstrumenterFactory.java Updated package declaration to the normalized versioned common package.
instrumentation/elasticsearch/elasticsearch-rest-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Singletons.java Updated import to the factory’s new package.
instrumentation/elasticsearch/elasticsearch-rest-6.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v6_4/ElasticsearchRest6Singletons.java Updated import to the factory’s new package.
instrumentation/elasticsearch/elasticsearch-rest-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v5_0/ElasticsearchRest5Singletons.java Updated import to the factory’s new package.

@trask trask merged commit 04f7761 into open-telemetry:main May 13, 2026
99 checks passed
@trask trask deleted the package-name-cleanup-elasticsearch-rest-common branch May 13, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants