Normalize JSF javaagent packages#18723
Merged
trask merged 1 commit intoMay 13, 2026
Merged
Conversation
trask
force-pushed
the
package-name-cleanup-jsf-packages
branch
from
0ddf149 to
1fe0772
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes the JSF javaagent instrumentation package names so they consistently live under io.opentelemetry.javaagent.instrumentation.jsf.*, aligning package structure with module paths and the broader package/module naming alignment effort (part of #18428).
Changes:
- Renamed MyFaces (1.2, 3.0) javaagent package declarations to
io.opentelemetry.javaagent.instrumentation.jsf.myfaces.*. - Renamed Mojarra (1.2, 3.0) javaagent package declarations to
io.opentelemetry.javaagent.instrumentation.jsf.mojarra.*. - Updated impacted static imports to the new package locations.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v3_0/Myfaces3Test.java | Aligns test package with normalized JSF/MyFaces 3.0 package path. |
| instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v3_0/RestoreViewExecutorInstrumentation.java | Moves instrumentation class into normalized JSF/MyFaces 3.0 package. |
| instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v3_0/MyFacesSingletons.java | Moves singleton holder into normalized JSF/MyFaces 3.0 package. |
| instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v3_0/MyFacesInstrumentationModule.java | Moves module entrypoint into normalized JSF/MyFaces 3.0 package. |
| instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v3_0/MyFacesErrorCauseExtractor.java | Moves error cause extractor into normalized JSF/MyFaces 3.0 package. |
| instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v3_0/ActionListenerImplInstrumentation.java | Updates package + singleton static import for normalized JSF/MyFaces 3.0 package. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/myfaces2Test/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/Myfaces2Test.java | Aligns MyFaces 2.x test package with normalized JSF/MyFaces 1.2 module structure. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/myfaces12Test/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/Myfaces12Test.java | Aligns MyFaces 1.2 test package with normalized JSF/MyFaces 1.2 module structure. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/RestoreViewExecutorInstrumentation.java | Moves instrumentation class into normalized JSF/MyFaces 1.2 package. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/MyFacesSingletons.java | Moves singleton holder into normalized JSF/MyFaces 1.2 package. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/MyFacesInstrumentationModule.java | Moves module entrypoint into normalized JSF/MyFaces 1.2 package. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/MyFacesErrorCauseExtractor.java | Moves error cause extractor into normalized JSF/MyFaces 1.2 package. |
| instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/myfaces/v1_2/ActionListenerImplInstrumentation.java | Updates package + singleton static import for normalized JSF/MyFaces 1.2 package. |
| instrumentation/jsf/jsf-mojarra-3.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v3_0/Mojarra3Test.java | Aligns test package with normalized JSF/Mojarra 3.0 package path. |
| instrumentation/jsf/jsf-mojarra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v3_0/RestoreViewPhaseInstrumentation.java | Moves instrumentation class into normalized JSF/Mojarra 3.0 package. |
| instrumentation/jsf/jsf-mojarra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v3_0/MojarraSingletons.java | Moves singleton holder into normalized JSF/Mojarra 3.0 package. |
| instrumentation/jsf/jsf-mojarra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v3_0/MojarraInstrumentationModule.java | Moves module entrypoint into normalized JSF/Mojarra 3.0 package. |
| instrumentation/jsf/jsf-mojarra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v3_0/ActionListenerImplInstrumentation.java | Updates package + singleton static import for normalized JSF/Mojarra 3.0 package. |
| instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/mojarra2Test/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v1_2/Mojarra2Test.java | Aligns Mojarra 2.x test package with normalized JSF/Mojarra 1.2 module structure. |
| instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/mojarra12Test/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v1_2/Mojarra12Test.java | Aligns Mojarra 1.2 test package with normalized JSF/Mojarra 1.2 module structure. |
| instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v1_2/RestoreViewPhaseInstrumentation.java | Moves instrumentation class into normalized JSF/Mojarra 1.2 package. |
| instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v1_2/MojarraSingletons.java | Moves singleton holder into normalized JSF/Mojarra 1.2 package. |
| instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v1_2/MojarraInstrumentationModule.java | Moves module entrypoint into normalized JSF/Mojarra 1.2 package. |
| instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jsf/mojarra/v1_2/ActionListenerImplInstrumentation.java | Updates package + singleton static import for normalized JSF/Mojarra 1.2 package. |
steverao
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of