Skip to content

Normalize Elasticsearch transport common javaagent package#18731

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-elasticsearch-transport-common
May 14, 2026
Merged

Normalize Elasticsearch transport common javaagent package#18731
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-elasticsearch-transport-common

Conversation

@trask

@trask trask commented May 13, 2026

Copy link
Copy Markdown
Member

@trask trask marked this pull request as ready for review May 13, 2026 14:02
Copilot AI review requested due to automatic review settings May 13, 2026 14:02
@trask trask requested a review from a team as a code owner May 13, 2026 14:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the Elasticsearch transport “common” javaagent/testing code with the module naming by moving it into the io.opentelemetry.javaagent.instrumentation.elasticsearch.transport.common package and updating downstream imports in the versioned Elasticsearch transport instrumentations/tests.

Changes:

  • Updated package declarations in elasticsearch-transport-common (javaagent + testing) to include the .common segment.
  • Updated imports in Elasticsearch transport 5.0, 5.3, and 6.0 instrumentations/tests to reference the new common package.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
instrumentation/elasticsearch/elasticsearch-transport-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/AbstractElasticsearchTransportClientTest.java Moves shared transport-client test base into the normalized .common package.
instrumentation/elasticsearch/elasticsearch-transport-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/AbstractElasticsearchNodeClientTest.java Moves shared node-client test base into the normalized .common package.
instrumentation/elasticsearch/elasticsearch-transport-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/AbstractElasticsearchClientTest.java Moves shared client test base into the normalized .common package.
instrumentation/elasticsearch/elasticsearch-transport-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/TransportActionListener.java Normalizes helper package for transport listener context propagation.
instrumentation/elasticsearch/elasticsearch-transport-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/ElasticTransportRequest.java Normalizes helper package for transport request wrapper.
instrumentation/elasticsearch/elasticsearch-transport-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/ElasticsearchTransportInstrumenterFactory.java Normalizes helper package for building the transport instrumenter.
instrumentation/elasticsearch/elasticsearch-transport-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/ElasticsearchTransportExperimentalAttributesExtractor.java Normalizes helper package for experimental attribute extraction.
instrumentation/elasticsearch/elasticsearch-transport-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/common/ElasticsearchTransportAttributesGetter.java Normalizes helper package for attribute getter used by instrumenters.
instrumentation/elasticsearch/elasticsearch-transport-6.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/AbstractElasticsearch6TransportClientTest.java Updates import to reference the new .common shared transport-client test base.
instrumentation/elasticsearch/elasticsearch-transport-6.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/AbstractElasticsearch6NodeClientTest.java Updates import to reference the new .common shared node-client test base.
instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/Elasticsearch6TransportSingletons.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/Elasticsearch6TransportExperimentalAttributesExtractor.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/Elasticsearch6TransportAttributesGetter.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/AbstractClientInstrumentation.java Updates common helper imports used by advice/listener wiring.
instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_3/Elasticsearch53TransportClientTest.java Updates import to reference the new .common shared transport-client test base.
instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_3/Elasticsearch53NodeClientTest.java Updates import to reference the new .common shared node-client test base.
instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_3/Elasticsearch53TransportSingletons.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_3/Elasticsearch53TransportExperimentalAttributesExtractor.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_3/Elasticsearch53TransportAttributesGetter.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_3/AbstractClientInstrumentation.java Updates common helper imports used by advice/listener wiring.
instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5TransportClientTest.java Updates import to reference the new .common shared transport-client test base.
instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5NodeClientTest.java Updates import to reference the new .common shared node-client test base.
instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5TransportSingletons.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5TransportExperimentalAttributesExtractor.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5TransportAttributesGetter.java Updates common helper imports to the new .common package.
instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/AbstractClientInstrumentation.java Updates common helper imports used by advice/listener wiring.

@trask trask merged commit 7b740f4 into open-telemetry:main May 14, 2026
99 checks passed
@trask trask deleted the package-name-cleanup-elasticsearch-transport-common branch May 14, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants